Menu

#5069 Avoid using void * as SCM

Verified
Maintainability
2017-03-06
2017-02-14
No

Avoid using void * as SCM

This is not really type-safe. Using an SCM * instead is unproblematic.

http://codereview.appspot.com/314500043

Discussion

  • Anonymous

    Anonymous - 2017-02-15
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-02-15

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-02-17
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-02-17

    Patch on countdown for February 20th.

     
  • Anonymous

    Anonymous - 2017-02-20
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-02-20

    patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2017-02-20
    • labels: --> Fixed_2_19_56
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2017-02-20

    Pushed to staging as
    commit 3fc70e3e7dfb3c26cb3e5bb9dcabc87cc758c24d
    Author: David Kastrup dak@gnu.org
    Date: Tue Feb 14 13:41:52 2017 +0100

    Issue 5069: Avoid using void * as SCM
    
    This is not really type-safe.  Using an SCM * instead is unproblematic.
    
     
  • Graham Percival

    Graham Percival - 2017-03-06
    • status: Fixed --> Verified