Menu

#5068 SCM/bool confusion in One_page_breaking::solve

Verified
Defect
2017-03-06
2017-02-14
No

SCM/bool confusion in One_page_breaking::solve

This replaces an accidentally always-true condition with the
originally intended one.

I have no idea about the consequences: it would be best if the
original author Paul Morris (in issue 4752) checked that this now
works as intended and also tried figuring out why we failed to notice
this problem.

http://codereview.appspot.com/314490043

Discussion

  • Anonymous

    Anonymous - 2017-02-14
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-02-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-02-17
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-02-17

    Patch on countdown for February 20th.

     
  • Anonymous

    Anonymous - 2017-02-20
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-02-20

    Patch counted down please push (unless Paul' comment on Rietveld makes you want to keep it on count down).

     
  • David Kastrup

    David Kastrup - 2017-02-20
    • labels: --> Fixed_2_19_56
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Defect
     
  • David Kastrup

    David Kastrup - 2017-02-20

    Discussion with Paul seemed to indicate that pushing this seems like a better option than not pushing it, so pushed to staging as
    commit b27fe425c189263be20830b09c859d27245bb550
    Author: David Kastrup dak@gnu.org
    Date: Tue Feb 14 13:33:13 2017 +0100

    Issue 5068: SCM/bool confusion in One_page_breaking::solve
    
    This replaces an accidentally always-true condition with the
    originally intended one.
    
     
  • Graham Percival

    Graham Percival - 2017-03-06
    • status: Fixed --> Verified