Let analysis brackets support text

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5064 Let analysis brackets support text

Status: Verified

Owner: Thomas Morley

Labels: Fixed_2_19_56 (7)

Needs:

Patch:

Type:

Updated: 2017-11-02

Created: 2017-02-08

Creator: Thomas Morley

Private: No

Let analysis brackets support text

Ability to add labels to brackets is essential for musical analysis.

This patch introduces a new grob, "HorizontalBracketText," a spanner
created along with "HorizontalBracket" by Horizontal_bracket_engraver.

Repeated text of broken brackets is parenthesized.

http://codereview.appspot.com/315570043

Discussion

Anonymous - 2017-02-08

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-08

passes make, make check, makelsr and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

Patch on countdown for February 14th.

Note there are some comments on Rietveld from Werner.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-14

Leaving on countdown (for Feb 17th) - there are some additions from Werner on Rietveld.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-02-15

reflect review

http://codereview.appspot.com/315570043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-16

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-16

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-17

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-17

Patch on countdown for February 20th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-20

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-20

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-02-20

labels: --> Fixed_2_19_56

status: Started --> Fixed

Patch: push -->

Type: Enhancement -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-02-20

Having shepherded this for David Nalesnik I pushed to staging:

commit dbc2dd143e50e000a39883fc8217b4ec60e08657
Author: David Nalesnik david.nalesnik@gmail.com
Date: Sat Feb 4 19:13:31 2017 -0600

Issue 5064 Let analysis brackets support text Ability to add labels to brackets is essential for musical analysis. This patch introduces a new grob, "HorizontalBracketText," a spanner created along with "HorizontalBracket" by Horizontal_bracket_engraver. Repeated text of broken brackets is parenthesized.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Phil Holmes - 2017-02-26

Note that when building with GUB, input/regression/horizontal-bracket-tweak.log produces the new error +programming error: Grob HorizontalBracketText' has no interface for propertythickness' continuing, cross fingers

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-02-28

This could be fixed by making the tweak a directed one -- i.e, naming HorizontalBracket in the tweak.

However, this isn't ideal.

Two questions:
(1) HorizontalBracketText grobs with no text are suicided in the print function. Perhaps this should be done earlier?
(2)
{
\tweak thickness 5 \tuplet 3/2 { r4 c d }
}

should cause the same problem, since none of TupletNumber's interfaces provides 'thickness

Any advice on how to proceed?

Thanks,
David

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-03-07

I'm waiting before marking it as verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-11-02

David N, should I open a new issue for above error? Or mark this as not fixed yet?

I'd like to clean all "not totally fixed issues" in the tracker.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- David Nalesnik - 2017-11-02
  
  Hi Federico,
  
  Sorry, I didn't see your March 7th message!
  
  On Thu, Nov 2, 2017 at 2:59 AM, Federico Bruni fedelibre@users.sf.net wrote:
  
  David N, should I open a new issue for above error? Or mark this as not
  fixed yet?
  
  I'd like to clean all "not totally fixed issues" in the tracker.
  
  The HorizontalBracketText grob comments are a non-issue. There might
  be cause for a new issue regarding the TupletNumber inconsistency, but
  I'm inclined to think it's more trouble than it's worth.
  
  Best,
  David
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-11-02

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-11-02

Ok David, I mark it as verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: