Fix extendersOverRests property

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5053 Fix extendersOverRests property

Status: Verified

Owner: David Kastrup

Labels: Fixed_2_19_55 (28)

Needs:

Patch:

Type: Enhancement

Updated: 2017-02-17

Created: 2017-02-04

Creator: David Kastrup

Private: No

Fix extendersOverRests property

This previously behaved as always-on.

Amend lyric-extender-rest regexp

The previous test only checked for a single setting of extendersOverRests .

http://codereview.appspot.com/317230043

1 Attachments

Screenshot_2017-02-05.png

Discussion

Anonymous - 2017-02-05

Description has changed:

Diff:

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +Screenshot_2017-02-05.png (42.6 kB; image/png)

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-05

Passes make, make check and a full make doc.

Reg test diff attached

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-02-05

Testing change as expected. Pity we don't have some two-stage procedure where one sees the difference under the same test. Maybe once we are no longer reviewing on Rietveld but on something like Gerrit, one can think of a way of achieving that.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-08

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-08

Patch on countdown for Feb 11th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

Patch counted down, please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

labels: --> Fixed_2_19_55

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-11

Issue 5053/1: Amend lyric-extender-rest regexp
author David Kastrup dak@gnu.org
Sat, 4 Feb 2017 13:32:14 +0000 (14:32 +0100)
committer David Kastrup dak@gnu.org
Sat, 11 Feb 2017 07:49:37 +0000 (08:49 +0100)
commit c40332b19b2224385f4221ede8fc29e57bbc3b01

Issue 5053/2: Fix extendersOverRests property
author David Kastrup dak@gnu.org
Sat, 4 Feb 2017 13:43:47 +0000 (14:43 +0100)
committer David Kastrup dak@gnu.org
Sat, 11 Feb 2017 07:49:37 +0000 (08:49 +0100)
commit 6c6d1f6ac9e6a7a9aba760dcbb41b4fbbc8f0536

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-02-17

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: