Menu

#5046 Remove some dead code from issue 1504

Verified
Maintainability
2017-02-17
2017-02-01
No

Remove some dead code from issue 1504

http://codereview.appspot.com/312380043

Discussion

  • Anonymous

    Anonymous - 2017-02-03
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-02-03

    Passes make, make check and a full make doe.

    Although I didn't expect to be able to do any patch testing for another 2 days or so, I pulled out an old (circa 10 years) Dell laptop at my parent's house, left to rot in a drawer, and managed to install Linux on it one rainy afternoon.

    So just for kicks I decided to see how long it would take to test a patch.

    1 dual core CPU (x86) with 4GB RAM.

    Make, make test-baseline/check and a full make doc ~ two and a half hours.

    Quicker than I expected.

     
  • Anonymous

    Anonymous - 2017-02-05
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-02-05

    Patch on countdown for February 8th.

     
  • Anonymous

    Anonymous - 2017-02-08
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-02-08

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2017-02-08
    • labels: --> Fixed_2_19_55
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2017-02-08

    Pushed to staging as
    commit fa2752d8e32002aa240d97a763f1bfcf35bd6aa0
    Author: David Kastrup dak@gnu.org
    Date: Wed Feb 1 21:23:21 2017 +0100

    Issue 5046: Remove some dead code from issue 1504
    
     
  • Federico Bruni

    Federico Bruni - 2017-02-17
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB