LilyIssues / Issues / #5039 Replace \set Staff.instrumentName with \with form in doc examples

Anonymous - 2017-01-23

status: New --> Started

assigned_to: pkx166h
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-23

NR: Replace \set Staff.instrumentName

Issue 5039

1st Patch - Notation Reference

Replace appropriate instances of

\set Staff.instrumentName = " ... "

with

\new Staff \with { instrumentName = " ... " }

http://codereview.appspot.com/313400043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-23

Minor indent fixes

http://codereview.appspot.com/313400043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-23

Fix missing TexInfo macro

http://codereview.appspot.com/313400043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-23

Needs: -->

Patch: new --> review

Type: --> Documentation
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-23

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-28

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-28

Patch on countdown for Jan 30th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

First Patch - Notation Reference

author James Lowe pkx@gnu.org
Mon, 23 Jan 2017 20:52:53 +0000 (20:52 +0000)
committer James Lowe pkx@gnu.org
Mon, 30 Jan 2017 16:02:40 +0000 (16:02 +0000)
commit 041cb33a404a829a8cdeeaebce17e45f613f10d8

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -16,4 +16,12 @@
 to the `\new Staff \with { ... }` form.
 There are quite a lot, and many more in the LSR, regression tests, etc.

+---
+This is/has been broken down into a number of small patches to make reviewing easier.

+http://codereview.appspot.com/313400043 - Notation Reference patch (pushed) 
+
+
+
+
+

Patch: push --> needs_work

Anonymous - 2017-01-30

LM: Replace \set Staff.instrumentName

Issue 5039

Second Patch - Learning Manual

Replace appropriate instances of

\set Staff.instrumentName = " ... "

with

\new Staff \with { instrumentName = " ... " }

http://codereview.appspot.com/314390043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -19,7 +19,9 @@
 ---
 This is/has been broken down into a number of small patches to make reviewing easier.

-http://codereview.appspot.com/313400043 - Notation Reference patch (pushed) 
+http://codereview.appspot.com/313400043 - Notation Reference patch (now pushed) 
+
+http://codereview.appspot.com/314390043 - Learning Manual patch (in review)

Needs: -->
Type: --> Documentation

Anonymous - 2017-01-30

Fix typo.

http://codereview.appspot.com/314390043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Fix some TexInfo formatting errors

http://codereview.appspot.com/314390043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Needs: -->

Patch: new --> review

Type: --> Documentation
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-02

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-02

Patch on countdown for February 5th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-05

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-05

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-05

Description has changed:

Diff:

--- old +++ new @@ -21,7 +21,7 @@ http://codereview.appspot.com/313400043 - Notation Reference patch (now pushed) -http://codereview.appspot.com/314390043 - Learning Manual patch (in review) +http://codereview.appspot.com/314390043 - Learning Manual patch (now pushed)

Patch: push --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-05

Learning Manual change

author James Lowe pkx@gnu.org
Mon, 30 Jan 2017 17:10:51 +0000 (17:10 +0000)
committer James Lowe pkx@gnu.org
Sun, 5 Feb 2017 13:11:21 +0000 (13:11 +0000)
commit 8069b823827dbd5aac35d1f61e09306eabfe1bde

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Replace \set Staff.instrumentName with \with form in doc examples

Issue Tracker for LilyPond

Searches

Help

#5039 Replace \set Staff.instrumentName with \with form in doc examples

Discussion