#5033 LyricHyphen whiteout

[Knut Petersen]

http://codereview.appspot.com/312530043 (Rietveld for attached patch)

Whiteout for LyricHyphen grobs is seldom used - obviously the hyphen must not whiteout parts of the lyric syllables. But it is a vital feature if mensuration lines are used (old music, Distler, ...)

A proper outline whiteout would be ideal, but it is not implemented ... the current code fails because you need a relatively large whiteout area for a small object. A brute force fix is to increase the number of iterations, but the result would be a pdf with a high percentage of whiteout code.

And there is the case where a long melisma produces a single hyphen event that generates a lot of hyphens that cross a number of mensuration lines. Rectangular or roundedbox whiteout will produce gaps in all mensuration lines crossed, even if there is no collision. That's not acceptable.

Attached is a patch that solves the problem. It passes a full make, and make check does not identify any problem.

WhiteoutOrig.jpg: Current code

WhiteoutImproved.jpg: Brute-force-fix - more than 90% whiteout code in the pdf

WhiteoutEvenBetter-X.jpg: Proposed behaviour as implemented in the attached patch

[Anonymous]

LyricHyphen whiteout

Issue 5033

A proper outline whiteout
would be ideal, but it is
not currently implemented.
The current code fails
because you need a relatively
large whiteout area for a
small object.

A brute force fix is to increase
the number of iterations, but
the result would be a pdf with
a high percentage of whiteout code.

There is the case where a long
melisma produces a single hyphen
event that generates a lot of
hyphens that cross a number of
mensuration lines.

Rectangular or roundedbox whiteout
will produce gaps in all
mensuration lines crossed, even
if there is no collision.

That's not acceptable.

http://codereview.appspot.com/312530043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for March 10th.

[Anonymous]

Patch counted down - Please phsh.

I'll push this for Knut,

[Anonymous]

author Knut Petersen knut_petersen@t-online.de
Sat, 4 Mar 2017 18:10:19 +0000 (18:10 +0000)
committer James Lowe pkx166h@gmail.com
Fri, 10 Mar 2017 18:32:08 +0000 (18:32 +0000)
commit 2dc76513c4edb8e18e6170069677eb0dd9b54209