I have held off submitting a patch update introducing documentation because of an existing error in snippets/new. If makelsr is part of the patch testing for the current issue, that error will lead to a failed doc build. Issue 5030 addresses this problem.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2017-01-15
Patch: countdown --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2017-01-15
Daivd, as 5030 has been pushed, and because Harm has some comments in Rietveld pertaining to the snippet, I think you can now submit a new patch for testing?
I'll put this back to review - unless you disagree with Harm (in which case as no one else has commented, this has gone through the full revieiw and can be pushed).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Harm is commenting on a new patchset, but there's really no reason for you to test it since I'm going to incorporate his new suggestions and put up patchset #3.
Going through another review/countdown cycle works for me..
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Pushed to staging as
commit c473929f7e9d1219a1fbe60ae0922d17c26fdefe
Author: David Nalesnik david.nalesnik@gmail.com
Date: Fri Jan 6 10:27:25 2017 -0600
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Attached is a file which illustrates the enhancement.
Oops.
Passes make, make check and a full make doc.
output from *.ly file attached
Diff:
Patch on countdown for Jan 14th
I have held off submitting a patch update introducing documentation because of an existing error in snippets/new. If makelsr is part of the patch testing for the current issue, that error will lead to a failed doc build. Issue 5030 addresses this problem.
Daivd, as 5030 has been pushed, and because Harm has some comments in Rietveld pertaining to the snippet, I think you can now submit a new patch for testing?
I'll put this back to review - unless you disagree with Harm (in which case as no one else has commented, this has gone through the full revieiw and can be pushed).
Harm is commenting on a new patchset, but there's really no reason for you to test it since I'm going to incorporate his new suggestions and put up patchset #3.
Going through another review/countdown cycle works for me..
improve snippet
http://codereview.appspot.com/315350043
Passes make, make check and a full make doc.
Patch on countdown for Jan 21st.
Patch counted down - please push.
Pushed to staging as
commit c473929f7e9d1219a1fbe60ae0922d17c26fdefe
Author: David Nalesnik david.nalesnik@gmail.com
Date: Fri Jan 6 10:27:25 2017 -0600