Menu

#5022 Allow fixed spacing of symbols in church rests

Verified
Enhancement
2017-02-16
2016-12-29
No

Allow fixed spacing of symbols in church rests

By default, the symbols making up a church rest are spread to fill
the available space in a measure.

Setting the new property "church-rest-inner-padding" places symbols
at the given distance from each other independently of measure width.
Settings are disregarded if symbols would overlap as a consequence
or would exceed the default separation, which is taken as a maximum.

http://codereview.appspot.com/319910043

1 Attachments

Related

Issues: #5022

Discussion

  • David Nalesnik

    David Nalesnik - 2016-12-29

    Here's a file illustrating the changes:

     
  • David Nalesnik

    David Nalesnik - 2016-12-29

    Add property to correct interface

    http://codereview.appspot.com/319910043

     
  • Anonymous

    Anonymous - 2016-12-30
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-12-30

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-12-30
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-12-30

    Patch on countdown for Jan 2nd

     
  • Anonymous

    Anonymous - 2017-01-02

    I'd like to keep this on one more countdown if I may - due mainly to the holiday period and perhaps some Developers might not have (yet) seen Dan's comments in Rietveld.

     
    • David Nalesnik

      David Nalesnik - 2017-01-02

      That's fine. I may ultimately decide to withdraw it if I don't get
      feedback concerning observations I've made on the mailing list. (I'm
      not convinced this problem is LilyPond's, rather one of too sparse
      typesetting on the part of the user.)

      On Mon, Jan 2, 2017 at 12:57 PM, pkx166h lilypond-pkx@users.sf.net wrote:

      I'd like to keep this on one more countdown if I may - due mainly to the
      holiday period and perhaps some Developers might not have (yet) seen Dan's
      comments in Rietveld.


      [issues:#5022] Allow fixed spacing of symbols in church rests

      Status: Started
      Created: Thu Dec 29, 2016 05:23 PM UTC by David Nalesnik
      Last Updated: Fri Dec 30, 2016 01:36 PM UTC
      Owner: David Nalesnik

      Allow fixed spacing of symbols in church rests

      By default, the symbols making up a church rest are spread to fill
      the available space in a measure.

      Setting the new property "church-rest-inner-padding" places symbols
      at the given distance from each other independently of measure width.
      Settings are disregarded if symbols would overlap as a consequence
      or would exceed the default separation, which is taken as a maximum.

      http://codereview.appspot.com/319910043


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/testlilyissues/issues/5022/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #5022

  • David Nalesnik

    David Nalesnik - 2017-01-05
     
  • David Nalesnik

    David Nalesnik - 2017-01-05

    Here's a file to test the new patch:

     
  • Anonymous

    Anonymous - 2017-01-07
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-01-07

    Passes make, make check and a full make doc.

    Attached is the output of the .ly file David provided with the patch.

     
  • Anonymous

    Anonymous - 2017-01-07
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +mm-expand-limit.png (30.6 kB; image/png)
    
     
  • Anonymous

    Anonymous - 2017-01-07

    Attachment

     
  • Anonymous

    Anonymous - 2017-01-08
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-01-08

    Patch on countdown for January 11th

     
  • Anonymous

    Anonymous - 2017-01-12
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-01-12

    Patch counted down - please push.

     
  • David Nalesnik

    David Nalesnik - 2017-01-12

    Pushed to staging as

    commit 7ba578d0e75eab7d78b4906bc6cdf7de10e077a2
    Author: David Nalesnik david.nalesnik@gmail.com
    Date: Fri Dec 23 10:39:12 2016 -0600

     
  • David Nalesnik

    David Nalesnik - 2017-01-12
    • labels: --> Fixed_2_19_55
    • status: Started --> Fixed
     
  • David Nalesnik

    David Nalesnik - 2017-01-12
    • Patch: push -->
     
  • Federico Bruni

    Federico Bruni - 2017-02-16
    • status: Fixed --> Verified