If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2017-01-11
I noticed this jumped from 'new' to 'review' without a test in between - I have no feelings either way about this, but wanted to confirm that is what you wanted?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
test (my first reply from my mobile email client was blocked by
sourceforge because Message-ID was missing in the header of my message)
James, I just forgot the workflow
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2017-01-13
Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2017-01-13
Federico, and of course the patch now no longer applies to master (because of the pushes made in the last few days) can you rebase and re-submit please? Sorry for the inconvenience.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Passes make, make check and a full make doc
Patch on countdown for Dec 24th.
I've followed Grahams's ok to push directly to staging without waiting for the countdown, as I'll be offline for a week since Sunday.
commit 9dbf6c2c5c8b2847cdfeb6d3c2d11d6f33d3a506 Author: Federico Bruni <...> Date: Tue Dec 20 16:33:58 2016 +0100 Doc: remove www from lilypond.org URLI can confirm that there are no more files with the @., form of the URL which have www, but
git grep "@uref{http://www.lilypond.org/"produces a bunch of files.
(the patch was successfuly applied, but problem isn't solved. Half-solved?)
replace remaining occurrences of www.lilypond.org with lilypond.org
Some occurrences of www.lilypond.org were overlooked in previous
patch for issue 5014. Command used:
git grep -l "@uref{http://www.lilypond.org/" | xargs sed -i "s|@uref{http://www.lilypond.org/|@uref{http://lilypond.org/|g"
http://codereview.appspot.com/315370043
I noticed this jumped from 'new' to 'review' without a test in between - I have no feelings either way about this, but wanted to confirm that is what you wanted?
test (my first reply from my mobile email client was blocked by
sourceforge because Message-ID was missing in the header of my message)
James, I just forgot the workflow
Federico, and of course the patch now no longer applies to master (because of the pushes made in the last few days) can you rebase and re-submit please? Sorry for the inconvenience.
replace remaining occurrences of www.lilypond.org with lilypond.org
Some occurrences of www.lilypond.org were overlooked in previous
patch for issue 5014. Command used:
git grep -l "@uref{http://www.lilypond.org/" | xargs sed -i "s|@uref{http://www.lilypond.org/|@uref{http://lilypond.org/|g"
http://codereview.appspot.com/313350043
This patch doesn't apply to current master, sorry, can you rebase it please?
ok, I'll do it again and push directly to staging as suggested by Graham yesterday
Pushed to staging:
commit 33fc42ac3a4638141254cf29abeb34cc61714a2d