Menu

#5005 Fix MusicXML reg tests that have both Lyrics and Chords

Verified
Enhancement
2017-01-11
2016-12-02
No

Fix MusicXML reg tests that have both Lyrics and Chords

As commented in the patch
I did not find any documentation
if a chord element can contain
multiple lyrics, so I just
assumed that the first note
of the chord contained the
Lyrics (consistant with
Finale and Muscore exports).

http://codereview.appspot.com/316950043

Discussion

  • Anonymous

    Anonymous - 2016-12-03
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-12-03

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-12-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-12-04

    Patch on countdown for Sun 7th Dec.

     
  • Anonymous

    Anonymous - 2016-12-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-12-07

    Patch counted down please push.

     
  • Anonymous

    Anonymous - 2016-12-07
    • labels: --> Fixed_2_19_53
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-12-07

    author Vincent Le Ligeour vincent.leligeour@gmail.com
    Wed, 7 Dec 2016 13:10:32 +0000 (13:10 +0000)
    committer James Lowe pkx166h@gmail.com
    Wed, 7 Dec 2016 13:10:38 +0000 (13:10 +0000)
    commit 503a553ab5a1ace4a4f03a321d2d353f253bf5f4

     
  • Graham Percival

    Graham Percival - 2017-01-11
    • status: Fixed --> Verified
     
  • Graham Percival

    Graham Percival - 2017-01-11

    I have verified that this commit is in git master.