Menu

#5003 unfoldRepeats can be restricted to certain repeat-types

Verified
Enhancement
2017-01-11
2016-12-01
No

unfoldRepeats can be restricted to certain repeat-types

It now takes an additional, optional argument.
It's a list of symbols representing the repeat-types which should
be unfolded.
Possible settings are percent-repeated-music, tremolo-repeated-music,
volta-repeated-music and of course repeated-music which is the
default and will unfold all.
A new regtest is added to cover the new feature.
Changes is extended accordingly.

Also correcting two small typos in Documentation/notation/staff.itely

http://codereview.appspot.com/318890043

Discussion

  • Anonymous

    Anonymous - 2016-12-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-12-02

    Passes make, make check and a full make doc.

     
  • Thomas Morley

    Thomas Morley - 2016-12-03
     
  • Thomas Morley

    Thomas Morley - 2016-12-03
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Thomas Morley

    Thomas Morley - 2016-12-04

    Use hash-table, fix articulate.ly

    http://codereview.appspot.com/318890043

     
  • Anonymous

    Anonymous - 2016-12-04

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-12-04
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-12-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-12-07

    Patch on countdown for December 10th.

     
  • Anonymous

    Anonymous - 2016-12-11
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-12-11

    Patch counted down, please push. Thank you.

     
  • Thomas Morley

    Thomas Morley - 2016-12-12
    • labels: --> Fixed_2_19_53
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2016-12-12

    pushed to staging as:

    commit ece789bf5f661cb8f16b50f87a248dedd6e1d8d5
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Thu Dec 1 22:38:54 2016 +0100

    Issue 5003 unfoldRepeats can be restricted to certain repeat-types
    
    It now takes an additional, optional argument.
    It's a list of symbols representing the repeat-types which should
    be unfolded.
    Possible settings are percent, tremolo and volta.
    The default is an empty list, for which repeated-music is taken,
    unfolding all.
    A new regtest is added to cover the new feature.
    Changes is extended accordingly.
    
    Also correcting two small typos in Documentation/notation/staff.itely
    
     
  • Graham Percival

    Graham Percival - 2017-01-11
    • status: Fixed --> Verified
     
  • Graham Percival

    Graham Percival - 2017-01-11

    I have verified that this patch is now in git master.