Menu ▾ ▴

#4989 Fix Type1 (PFA and PFB) font embedding

Verified
Masamichi Hosoda
Fixed_2_19_50 (8)
Enhancement
2016-11-08
2016-10-26
Masamichi Hosoda
No

Fix Type1 (PFA and PFB) font embedding

Issue 4989/3: Add a guard against invalid Type 1 (PFB) font

This commit makes LilyPond can detect invalid Type1 (PFB) font.

Issue 4989/2: Fix Type 1 (PFB) font embedding

Type 1 PFA data which is converted from PFB files can contain '\0'.

In order to avoid problems with '\0',
this commit makes to use the file length
instead of zero-terminated string.

Issue 4989/1: Fix Type 1 (PFA) font embedding

Type 1 (PFA) fonts can contain '\0'.
e.g. URW++ June 2016 (Ghostscript 9.20)

In order to avoid problems with '\0',
this commit makes to use the file length
instead of zero-terminated string.

http://codereview.appspot.com/313930043

Discussion

  • Masamichi Hosoda

    Masamichi Hosoda - 2016-10-27

    Use stringstream and add PFB error check

    http://codereview.appspot.com/313930043

     

  • Masamichi Hosoda

    Masamichi Hosoda - 2016-10-27
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,20 +1,24 @@
 Fix Type1 (PFA and PFB) font embedding

-Fix Type1 (PFB) font embedding
+Issue 4989/3: Add a guard against invalid Type 1 (PFB) font

-Type1 PFA data which is converted from PFB files can contain '\0'.
+  This commit makes LilyPond can detect invalid Type1 (PFB) font.

-In order to avoid problems with '\0',
-this commit makes to use the file length
-instead of zero-terminated string.
+Issue 4989/2: Fix Type 1 (PFB) font embedding

-Fix Type1 (PFA) font embedding
+  Type 1 PFA data which is converted from PFB files can contain '\0'.

-Type1 (PFA) fonts can contain '\0'.
-e.g. URW++ June 2016 (Ghostscript 9.20)
+  In order to avoid problems with '\0',
+  this commit makes to use the file length
+  instead of zero-terminated string.

-In order to avoid problems with '\0',
-this commit makes to use the file length
-instead of zero-terminated string.
+Issue 4989/1: Fix Type 1 (PFA) font embedding
+
+  Type 1 (PFA) fonts can contain '\0'.
+  e.g. URW++ June 2016 (Ghostscript 9.20)
+
+  In order to avoid problems with '\0',
+  this commit makes to use the file length
+  instead of zero-terminated string.

 http://codereview.appspot.com/313930043
    • Needs: -->
    • Type: -->
     

  • Anonymous

    Anonymous - 2016-10-28
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2016-10-28

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2016-10-31
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2016-10-31

    Patch on countdown for November 3rd.

     

  • Anonymous

    Anonymous - 2016-11-03
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2016-11-03

    Patch counted down - please push

     

  • Masamichi Hosoda

    Masamichi Hosoda - 2016-11-04
    • labels: --> Fixed_2_19_50
    • status: Started --> Fixed
    • Patch: push -->
     

  • Masamichi Hosoda

    Masamichi Hosoda - 2016-11-04

    I've pushed.

    Issue 4989/3: Add a guard against invalid Type 1 (PFB) font
    commit 3ec0872f35d8ab79d07127c3e7be5f08977c2394

    Issue 4989/2: Fix Type 1 (PFB) font embedding
    commit 65a0059b69385985896a24f407b3a791d33aef0f

    Issue 4989/1: Fix Type1 (PFA) font embedding
    commit 1e0bc03d9e50ea4d69e08fdbb0a85e56203299f2

     

  • Federico Bruni

    Federico Bruni - 2016-11-08
    • status: Fixed --> Verified