Menu

#4972 Chord repetition erroneously tagged

Verified
Enhancement
2016-11-04
2016-09-15
Phil Holmes
No

Peter Crighton reported that in the code below, in the third measure the chord repetition symbol
seems to get tagged as well, although only the markup should:

\version "2.19.47"

x = \tag #'tabstaff ^x

music = \relative c {
  c4 c c c\x
  <c e> <c e> <c e> <c e>\x
  q q q q\x
}

\new StaffGroup <<
  \new Staff \keepWithTag #'staff <<
    \clef "treble_8"
    \music
  >>
  \new TabStaff \keepWithTag #'tabstaff <<
    \tabFullNotation
    \music
  >>
>>
1 Attachments

Discussion

  • David Kastrup

    David Kastrup - 2016-09-15

    Issue 4972: Make music-filter more conservative

    Deleting music when its 'elements field becomes null? led
    to repeat chords disappearing when articulations were
    removed.

    http://codereview.appspot.com/303570043

     
  • Phil Holmes

    Phil Holmes - 2016-09-15
    • assigned_to: David Kastrup
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2016-09-16
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-09-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-09-25
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-09-25

    Patch on countdown for September 28th

     
  • Anonymous

    Anonymous - 2016-09-28
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-09-28

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2016-09-28
    • labels: --> Fixed_2_19_49
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-09-28

    author David Kastrup dak@gnu.org
    Thu, 15 Sep 2016 13:50:14 +0100 (14:50 +0200)
    committer David Kastrup dak@gnu.org
    Wed, 28 Sep 2016 08:28:14 +0100 (09:28 +0200)
    commit 8a493b7bc9aa4d34cd2970fc2223ec6920f0ed02

     
  • Federico Bruni

    Federico Bruni - 2016-11-04
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.