If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-08-30
This fails a make doc.
Fails on the website are trickier to decipher than the regular docs (I don't know why as I don't understand the technical differences) but it seems that this failure is being triggered by the removal of the @node * Old news:: from community.itexi.
I am getting a specific complaint (undefined node) from the the dutch translations (i.e. Documentation/nl/web/community.itexi)
So you will need to go back into the translations and make sure that there are no more references to this 'Old news' node.
Some of the translations will not have this node at all, but that is OK (they post warnings but they are not fatal). It's only when you have translations that use @node names in @refs{} that get moved that you have to be careful of.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks, I should have tried the full make doc (make website succeeded). I've uploaded patch set 2 that succeeds with make doc for me locally. You were right that changing all the instances of 'Old news' to 'News' in all the translations fixed it.
James, sorry about that, I must be a little rusty and forgot to rebase before uploading. Anyway, from the review it seems this patch also needs work in other ways, so I won't rebase and upload this version again.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-16
Needs: -->
Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-16
I am struggling to apply the diff file from Rietveld:
--snip--
jlowe@jloweDesktop ~/lilypond-git $ git apply --index ~/Desktop/issuexxx.diff
/home/jlowe/Desktop/issuexxx.diff:364: trailing whitespace.
% Engrave to png with these options to create
/home/jlowe/Desktop/issuexxx.diff:369: trailing whitespace.
% itself is simply the image from the essay manual,
error: missing binary patch data for 'Documentation/pictures/bwv861-lilypond-large.png'
error: binary patch does not apply to 'Documentation/pictures/bwv861-lilypond-large.png'
error: Documentation/pictures/bwv861-lilypond-large.png: patch does not apply
error: missing binary patch data for 'Documentation/pictures/bwv861-lilypond.png'
error: binary patch does not apply to 'Documentation/pictures/bwv861-lilypond.png'
error: Documentation/pictures/bwv861-lilypond.png: patch does not apply
--snip--
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-16
Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi James, I've uploaded patch set 5 which removes the image and ly files from the patch, and should allow it to be applied. These files need to be in lilypond-extra for the website anyway, so they don't need to be in this patch. (Other website images are in both places so that's why I had included them in the last round... the documentation is sparse on how all this should work.)
I've already done a pull request to add the images to the lilypond-extra directory on github, and can do the same with the ly file as well (although I'm not sure the best place for it to live inside that directory).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-17
Needs: -->
Patch: new --> review
Type: --> Documentation
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-17
PAsses make, make check and a full make doc.
The new patch failed with a 'missing' file error, so I ended up applying the diff at Rietveld and then applying the three new files you added to lilypond-extra, and that worked. So I guess as long as all the files push to staging it will then compile and be merged into master.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-18
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-09-18
Patch on countdown for Sept 21st
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
This fails a make doc.
Fails on the website are trickier to decipher than the regular docs (I don't know why as I don't understand the technical differences) but it seems that this failure is being triggered by the removal of the @node * Old news:: from community.itexi.
I am getting a specific complaint (undefined node) from the the dutch translations (i.e. Documentation/nl/web/community.itexi)
So you will need to go back into the translations and make sure that there are no more references to this 'Old news' node.
Some of the translations will not have this node at all, but that is OK (they post warnings but they are not fatal). It's only when you have translations that use @node names in @refs{} that get moved that you have to be careful of.
Thanks, I should have tried the full make doc (make website succeeded). I've uploaded patch set 2 that succeeds with make doc for me locally. You were right that changing all the instances of 'Old news' to 'News' in all the translations fixed it.
Patch set 2 also includes a second commit:
All 'Old news' -> 'News' & rearrange examples
http://codereview.appspot.com/306350043
Paul sorry to be a pain but this new patch doesn't apply to current master - you may need to rebase it.
James, sorry about that, I must be a little rusty and forgot to rebase before uploading. Anyway, from the review it seems this patch also needs work in other ways, so I won't rebase and upload this version again.
One example on homepage with anchor links
http://codereview.appspot.com/306350043
Passes make, make check and a full make doc.
There are some comments on Rietveld but we're bike-shedding at this point :) nothing that I can see that prevents this from being moved on.
Patch on countdown for Sept 11th
Patch counted down - please push.
Use Bach BWV861 example from essay
http://codereview.appspot.com/306350043
I am struggling to apply the diff file from Rietveld:
--snip--
jlowe@jloweDesktop ~/lilypond-git $ git apply --index ~/Desktop/issuexxx.diff
/home/jlowe/Desktop/issuexxx.diff:364: trailing whitespace.
% Engrave to png with these options to create
/home/jlowe/Desktop/issuexxx.diff:369: trailing whitespace.
% itself is simply the image from the essay manual,
error: missing binary patch data for 'Documentation/pictures/bwv861-lilypond-large.png'
error: binary patch does not apply to 'Documentation/pictures/bwv861-lilypond-large.png'
error: Documentation/pictures/bwv861-lilypond-large.png: patch does not apply
error: missing binary patch data for 'Documentation/pictures/bwv861-lilypond.png'
error: binary patch does not apply to 'Documentation/pictures/bwv861-lilypond.png'
error: Documentation/pictures/bwv861-lilypond.png: patch does not apply
--snip--
Remove image and ly files from patch
http://codereview.appspot.com/306350043
Hi James, I've uploaded patch set 5 which removes the image and ly files from the patch, and should allow it to be applied. These files need to be in lilypond-extra for the website anyway, so they don't need to be in this patch. (Other website images are in both places so that's why I had included them in the last round... the documentation is sparse on how all this should work.)
I've already done a pull request to add the images to the lilypond-extra directory on github, and can do the same with the ly file as well (although I'm not sure the best place for it to live inside that directory).
PAsses make, make check and a full make doc.
The new patch failed with a 'missing' file error, so I ended up applying the diff at Rietveld and then applying the three new files you added to lilypond-extra, and that worked. So I guess as long as all the files push to staging it will then compile and be merged into master.
Patch on countdown for Sept 21st