Menu

#4960 Fix micro-tones assigned to strings in TabStaff

Verified
Enhancement
2016-11-04
2016-08-26
No

Fix micro-tones assigned to strings in TabStaff

This is an oversight from issue 4643
Also extending input/regression/tablature-micro-tone.ly to cover this case.

http://codereview.appspot.com/308230043

1 Attachments

Discussion

  • Thomas Morley

    Thomas Morley - 2016-08-26

    Test-case:

    \version "2.19.46"
    
    \layout {
      \context {
        \Score
        supportNonIntegerFret = ##t
      }
    }
    
    \new TabStaff { gih\6 }
    

    Although it is printed correctly, needless warnings are printed.

     
  • Anonymous

    Anonymous - 2016-08-27
    • Description has changed:

    Diff:

    
    
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +RegTestDiff.png (163.7 kB; image/png)
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-08-27

    Passes make, make check and a full make doc.

    Reg test diff attached

     
  • Thomas Morley

    Thomas Morley - 2016-08-27

    Reg test diff as expected

     
  • Anonymous

    Anonymous - 2016-08-30
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-08-30

    Patch on countdown for Sept 2nd

     
  • Anonymous

    Anonymous - 2016-09-02
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-09-02

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2016-09-02
    • labels: --> Fixed_2_19_48
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2016-09-02

    pushed to staging as:
    commit 46a056a27c59a31ed53f20e27f8e2772dcbea0d0
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Sat Aug 27 00:32:30 2016 +0200

    Issue 4960 Fix micro-tones assigned to strings in TabStaff
    
    This is an oversight from issue 4643
    Also extending input/regression/tablature-micro-tone.ly to cover this case.
    
     
  • Federico Bruni

    Federico Bruni - 2016-11-04
    • status: Fixed --> Verified