Menu

#4958 Expand description of the engraver hooks

Verified
Documentation
2016-11-04
2016-08-24
No

The Engraver Tutorial section in the CG (section 10.11) should be improved by expanding the description of the way the several engraver hooks work along the lines of the recent mail from David Kastrup:
http://lists.gnu.org/archive/html/lilypond-devel/2016-08/msg00145.html

Discussion

  • Trevor Daniels

    Trevor Daniels - 2016-08-24

    Doc: Issue 4958: CG: Expand description of the engraver hooks

    The description of the stop-translator-timestep hook did not
    make it clear that grobs must not be created there.

    http://codereview.appspot.com/310070043

     
  • Trevor Daniels

    Trevor Daniels - 2016-08-24
    • status: Started --> Accepted
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2016-08-27
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2016-08-27

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-08-27
    • status: Accepted --> Started
     
  • Anonymous

    Anonymous - 2016-08-30
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-08-30

    Patch on countdown for Sept 2nd.

     
  • Anonymous

    Anonymous - 2016-09-02
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-09-02

    Patch counted down - please push

     
  • Trevor Daniels

    Trevor Daniels - 2016-09-02

    Pushed to Staging as
    7a6871397b80a624067ced8381fced65d4f6f246

    Author: Trevor Daniels t.daniels@treda.co.uk 2016-09-02 23:08:18
    Committer: Trevor Daniels t.daniels@treda.co.uk 2016-09-02 23:09:05

    Doc: Issue 4958: CG: Expand description of the engraver hooks
    
    The previous rather terse description did not make it clear
    that grobs may not be created in the stop-translation-timestep
    hook.
    
    Thanks to David K for the text.
    
     

    Last edit: Trevor Daniels 2016-09-02
  • Trevor Daniels

    Trevor Daniels - 2016-09-02
    • labels: --> Fixed_2_19_48
    • status: Started --> Fixed
    • Patch: push -->
     
  • Federico Bruni

    Federico Bruni - 2016-11-04
    • status: Fixed --> Verified