Menu

#4956 Change \retrograde to deal with ties and repeat chords/notes

Verified
Enhancement
2016-11-04
2016-08-15
No

Change \retrograde to deal with ties and repeat chords/notes

Consists of commits:

Remove warning about ties in \retrograde

Change retrograde-music function to deal with ties

Let \retrograde expand repeat chords/notes

Since those lose their point of reference, expanding them
prior to retrograding keeps the results sane.

http://codereview.appspot.com/302470043

Related

Issues: #3445

Discussion

  • David Kastrup

    David Kastrup - 2016-08-16

    Regtest and fixes for glissandi, \<, > and docs

    http://codereview.appspot.com/302470043

     
  • Anonymous

    Anonymous - 2016-08-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-08-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-08-18
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-08-18

    Patch on countdown for the 21st August.

     
  • Anonymous

    Anonymous - 2016-08-21
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-08-21

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-08-23
    • labels: --> Fixed_2_19_47
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-08-23

    Pushed to staging as
    commit aa516b66c0e603146f94bee9dc74408262792977
    Author: David Kastrup dak@gnu.org
    Date: Mon Aug 15 19:09:52 2016 +0200

    Issue 4956/3: Augment warning about \retrograde
    
    Ties work now, but the documentation points out a lot of other
    shortcomings.
    

    commit 6fcbd2a18b171f56ec873520a3c3de2e028a0a04
    Author: David Kastrup dak@gnu.org
    Date: Mon Aug 15 17:41:04 2016 +0200

    Issue 4956/2: Improve retrograde-music function
    
    This allows to work with ties and glissandi, makes somewhat useful
    changes for overrides, changes crescendi to descrescendi and vice versa.
    

    commit b757ca820a230ef7393f6ed81e6aceda723caf26
    Author: David Kastrup dak@gnu.org
    Date: Mon Aug 15 17:40:05 2016 +0200

    Issue 4956/1: Let \retrograde expand repeat chords/notes
    
    Since those lose their point of reference, expanding them
    prior to retrograding keeps the results sane.
    
     
  • David Kastrup

    David Kastrup - 2016-08-23

    Oh, and obviously also
    commit 1e678c08e37073ffac482618655dc87308e5c0b4
    Author: David Kastrup dak@gnu.org
    Date: Tue Aug 16 16:23:57 2016 +0200

    Issue 4956/4: Add regtest for \retrograde
    

    Sorry for forgetting this one.

     
  • Federico Bruni

    Federico Bruni - 2016-11-04
    • status: Fixed --> Verified