Menu

#4949 Keep a staff alive with multiple layers

Verified
mkdev
Enhancement
2016-11-04
2016-08-01
mkdev
No

Keep a staff alive with multiple layers

This allows the `VerticalAxisGroup.remove-layer' property to
accept a list of values. The layer will stay alive with any
other member of the Keep_alive_together_engrave group with a
remove-layer value in that list.

The principal reason for this patch was to allow the use of
MarkLine contexts in a Frenched score, where the context should
stay alive with any single staff in a StaffGroup. This
implementation should also allow additional flexibility with ossia
and divisi staves.

http://codereview.appspot.com/308910043

Related

Issues: #4949

Discussion

1 2 > >> (Page 1 of 2)
  • Anonymous

    Anonymous - 2016-08-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-08-02

    Passes make,. make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-08-03
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2016-08-03

    This looks like it needs some more work (from Rietveld).

     
  • mkdev

    mkdev - 2016-08-12

    Use key? (integer or symbol)

    http://codereview.appspot.com/308910043

     
  • Anonymous

    Anonymous - 2016-08-12
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-08-12

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-08-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-08-15

    Patch on countdown for August 18th but please see comments on Rietveld that (I think) need to be addressed. Thanks.

     

    Last edit: Anonymous 2016-08-15
  • Anonymous

    Anonymous - 2016-08-18
    • Patch: countdown --> review
     
  • Anonymous

    Anonymous - 2016-08-18

    From discussions on Rietveld I am going to set this back to Review for now.

     
  • Anonymous

    Anonymous - 2016-08-21
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2016-08-21

    Setting this patch to 'needs_work' as nothing has changed in Rietveld since the 18th

     
  • mkdev

    mkdev - 2016-08-21

    Group lower-level contexts

    http://codereview.appspot.com/308910043

     
  • Anonymous

    Anonymous - 2016-08-22
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-08-22

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-08-24
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-08-24

    Patch on countdown for August 27th - although there are some comments on Rietveld that need addressing beforehand I think.

     
  • Anonymous

    Anonymous - 2016-08-27
    • Patch: countdown --> needs_work
     
  • Anonymous

    Anonymous - 2016-08-27

    This looks like it still needs more work.

     
  • mkdev

    mkdev - 2016-09-03

    git-cl failed to update this, so adding this manually.

    Patch set 4: Remove keep-alive-group properties, add above/below symbols uploaded to Rietvelt.

    https://codereview.appspot.com/308910043/

     
  • Anonymous

    Anonymous - 2016-09-04
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-09-04

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-09-05
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-09-05

    Patch on countdown for Sept 8th.

     
1 2 > >> (Page 1 of 2)