LilyIssues / Issues / #4931 make \deadNote work with different fonts

Description has changed:

Diff:

--- old
+++ new
@@ -3,4 +3,4 @@

 When using \deadNote and override TabNoteHead.font-name with a font different from Feta, dead notes are not printed on TabStaff and the following warning appears in the console:

-warning: none of note heads `noteheads.s' or `noteheads.u' found
+warning: none of note heads `noteheads.s` or `noteheads.u` found

Thomas Morley - 2016-07-27

Issue 4931 make deadNote work with other font-settings

This is done by temporarily setting font-name to '(), causing the
default-font (usually Feta) to take over, reverting this later.
The regtest dead-notes.ly is altered accordingly.
Also, ly-syntax is used where possible.
palmMute and harmonic are not affected by this patch and still
work nicely.

http://codereview.appspot.com/309780043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-07-27

status: Accepted --> Started

assigned_to: Thomas Morley

Needs: -->

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-07-27

regtest-version corrected

http://codereview.appspot.com/309780043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-07-27

adressing Davids comment

http://codereview.appspot.com/309780043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-07-27

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-07-27

Because of some surgery tomorrow I'll set this to needs-work.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-01-08

rebase, clean-up, comment extended

http://codereview.appspot.com/309780043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-08

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +Screenshot.png (135.5 kB; image/png)

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-08

Passes make, make check and a full make doc.

Reg test diff attached

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-01-09

Reg test as expected. Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-12

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-12

Patch on countdown for Jan 14th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-15

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-15

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2017-01-15

labels: --> Fixed_2_19_55

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

pushed to staging as:

commit 1c7aa062c6cec594b68479b240db33399f80f4e6
Author: Thomas Morley thomasmorley65@gmail.com
Date: Wed Jul 27 11:46:55 2016 +0200

Issue 4931 make deadNote work with other font-settings

In case the current (text-)font does not contain a cross-glyph,
font-name is set temporary to '(), and font-family to feta.
If feta is replaced with another font without glyphs for cross-style
note-heads, it will still fail, though.
The regtest dead-notes.ly is altered accordingly.
Also, ly-syntax is used where possible.
palmMute and harmonic are not affected by this patch and still
work nicely.

Federico Bruni - 2017-01-16

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-01-16

Thanks Harm! I've tested some of my scores and I confirm that it works.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

make \deadNote work with different fonts

Issue Tracker for LilyPond

Searches

Help

#4931 make \deadNote work with different fonts

Discussion