#4912 Fix output definition use in \book and \bookpart

[David Kastrup]

Fix output definition use in \book and \bookpart

The only explicit output definition blocks allowed in \book and
\bookpart blocks were paper blocks. Output definitions supplied with
Scheme expressions were erroneously interpreted like global output
definitions, accepting all output definition types and overriding the
global defaults with them.

Now the only output definitions accepted as Scheme expressions are
paper blocks. As opposed to previously, they actually set the paper
block of the respective book or bookpart.

http://codereview.appspot.com/299490043

[Anonymous]

Passes make, make check and a full make doc.

sigh..

more programming errors - only on the midi regression tests - as before I will assume these are an artefact of testing than real errors.

--snip--

@@ -15,3 +15,7 @@
Writing ./dynamic-initial-midi-systems.tex...
Writing ./dynamic-initial-midi-systems.count...
Writing timing to dynamic-initial-midi.profile...
+programming error: Parsed object should be dead: #<prob: music="" c++:="" music((origin="" .="" #\<location="" out-test="" dynamic-initial-midi.ly:40:3="">) (value . +ew:) (symbol . instrumentName))((display-methods #\<procedure #f="" (expr)="">) (name . PropertySet) (types layout-instruction-event) (iterator-ctor . #\<primitive-procedure ly:property-iterator::constructor="">) (untransposable . #t)) >
+
+continuing, cross fingers</primitive-procedure></procedure></prob:>

--snip--

if not please can you set the issue back to needs_work

[David Kastrup]

They'll be unrelated to this issue (since this issue's code is rather unlikely to get exercised, in particular not with the Midi tests). Do you remember whether the previous occurence of problems was also with the Midi tests? That does not necessarily mean something Midi-related: I think that all the Midi tests are run with a single command so basically it's not unusual if something like that repeats itself when it triggers randomly.

[Anonymous]

Do you remember whether the previous occurence of problems was also with the Midi tests?

If you mean just the MIDI tests then no I don't think so, but I will keep an eye out next time.

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for July 7th.

[Anonymous]

Patch counted down - please push.

[David Kastrup]

Pushed to staging as
commit 22799b630629f695044ea6e5ee0c79b429e962f3
Author: David Kastrup dak@gnu.org
Date: Sat Jul 2 10:08:42 2016 +0200

Issue 4912: Fix output definition use in \book and \bookpart

The only explicit output definition blocks allowed in \book and
\bookpart blocks were paper blocks.  Output definitions supplied with
Scheme expressions were erroneously interpreted like global output
definitions, accepting all output definition types and overriding the
global defaults with them.

Now the only output definitions accepted as Scheme expressions are
paper blocks.  As opposed to previously, they actually set the paper
block of the respective book or bookpart.