Menu

#4906 ADD_ACKNOWLEDGER/LISTENER_FOR

Verified
Maintainability
2016-07-17
2016-06-26
No

ADD_ACKNOWLEDGER/LISTENER_FOR

Add macros allowing to listen/acknowledge to events/grobs unrelated
to the actual listener name.

This is actually conflating a few issues tampering with the same code.
If review is unhappy about some parts, they can still be split out and
treated separately.

Also contains commits:

Use ADD_END_ACKNOWLEDGER_FOR in slur engravers

Don't let ADD_END_ACKNOWLEDGER_FOR add end_ to callback

[Note that those two commits might be a bit contentious. They make it
possible to get rid of Slur::acknowledge_end_tie as a stub calling
Slur::acknowledge_extra_object. The savings are not exactly
overwhelming, but there does not seem to be any other use of
ADD_END_ACKNOWLEDGER_FOR otherwise]

Use ADD_LISTENER/ACKNOWLEDGER_FOR in slur engravers

Rename ack_trampoline to trampoline

This allows foregoing a dummy Translator::ack_trampoline definition.

Rename ack_finder to method_finder

This additional overload streamlines things somewhat.

[Those last two commits are independent changes but touch the same code lines]

http://codereview.appspot.com/301070043

Discussion

  • David Kastrup

    David Kastrup - 2016-06-26
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Type: Enhancement --> Maintainability
     
  • Anonymous

    Anonymous - 2016-06-27
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-06-27

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-30
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-30

    Patch on countdown for July 3rd.

     
  • Anonymous

    Anonymous - 2016-07-04
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-07-04

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-07-04
    • labels: --> Fixed_2_19_45
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-07-04

    Pushed to staging as
    commit 6acce8f4c900bee88c85a45b9ed1b29983891469
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 19 16:37:43 2016 +0200

    Issue 4906/6: Use ADD_END_ACKNOWLEDGER_FOR in slur engravers
    

    commit 369988ff777e4cec3228ee02a77f11e154cc842b
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 19 16:36:57 2016 +0200

    Issue 4906/5: Don't let ADD_END_ACKNOWLEDGER_FOR add end_ to callback
    

    commit ca91c4fef862a54df0c4af18235883518c475576
    Author: David Kastrup dak@gnu.org
    Date: Sat Jun 18 18:25:25 2016 +0200

    Issue 4906/4: Use ADD_LISTENER/ACKNOWLEDGER_FOR in slur engravers
    

    commit 3d76daf5b141b8ceeb3a04a7d001bfec857e1f1e
    Author: David Kastrup dak@gnu.org
    Date: Mon Jun 6 13:54:40 2016 +0200

    Issue 4906/3: ADD_ACKNOWLEDGER/LISTENER_FOR
    
    Add macros allowing to listen/acknowledge to events/grobs unrelated
    to the actual listener name.
    

    commit 1a4fcab3c11fc6523874bce6b5dfd37c362f22d6
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 26 09:49:30 2016 +0200

    Issue 4906/2: Rename ack_trampoline to trampoline
    
    This allows foregoing a dummy Translator::ack_trampoline definition.
    

    commit 04f4d06dbdb8473548f2caec6da5d64e53804a30
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 26 00:32:38 2016 +0200

    Issue 4906/1: Rename ack_finder to method_finder
    
    This additional overload streamlines things somewhat.
    
     
  • Federico Bruni

    Federico Bruni - 2016-07-17
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB