Menu

#4904 Reimplement issue 4781 for musicxml2ly more literally.

Verified
Enhancement
2016-07-17
2016-06-23
No

Reimplement issue 4781 for musicxml2ly more literally.
Reimplementation was necessary as part of the implementation of issue 4751, but some of the code changes for 4781 were omitted. This reproduces all the 4781 changes.

http://codereview.appspot.com/302050043

Related

Issues: #4904

Discussion

  • Anonymous

    Anonymous - 2016-06-25
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-06-25

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-27

    Patch on countdown for June 30th.

     
  • Anonymous

    Anonymous - 2016-06-30
    • Patch: countdown --> push
     
    • John Gourlay

      John Gourlay - 2016-06-30

      The push has been done.

      On Jun 30, 2016, at 12:06 PM, pkx166h lilypond-pkx@users.sf.net wrote:

      • Patch: countdown --> push
      • Comment:
      Patch counted down - please push

      [issues:#4904] Reimplement issue 4781 for musicxml2ly more literally.

      Status: Started
      Created: Thu Jun 23, 2016 08:00 PM UTC by John Gourlay
      Last Updated: Mon Jun 27, 2016 11:46 AM UTC
      Owner: John Gourlay

      Reimplement issue 4781 for musicxml2ly more literally.
      Reimplementation was necessary as part of the implementation of issue 4751, but some of the code changes for 4781 were omitted. This reproduces all the 4781 changes.

      http://codereview.appspot.com/302050043

      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/4904/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #4904

  • Anonymous

    Anonymous - 2016-06-30

    Patch counted down - please push

     
  • John Gourlay

    John Gourlay - 2016-06-30

    Reimplement issue 4781 more literally.

    http://codereview.appspot.com/302050043

     
  • Anonymous

    Anonymous - 2016-07-01
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-07-01

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-07-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-07-04

    Patch on countdown for July 7th.

     
  • Anonymous

    Anonymous - 2016-07-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-07-07

    Patch counted down - please push.

     
  • John Gourlay

    John Gourlay - 2016-07-07

    The changes have been pushed to staging today. I thought I did this a week ago, but apparently I did something wrong at that time. I double checked staging and the changes are there.

     
  • Anonymous

    Anonymous - 2016-07-11
    • labels: --> Fixed_2_19_45
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-07-11

    author John Gourlay john@weathervanefarm.net
    Thu, 23 Jun 2016 20:49:25 +0100 (15:49 -0400)
    committer John Gourlay john@weathervanefarm.net
    Thu, 7 Jul 2016 18:31:50 +0100 (13:31 -0400)
    commit 15115dd5c9b20b7fe6b1ee4f09f52a2c7c9bbe93

     
  • Federico Bruni

    Federico Bruni - 2016-07-17
    • status: Fixed --> Verified