Menu

#4898 Set rhythmic-location early in paper-column-engraver

Verified
Enhancement
2016-07-17
2016-06-17
No

Set rhythmic-location early in paper-column-engraver

This makes it possible to refer to rhythmic-location in callbacks
for PaperColumn grobs.

This one annoyed me when I was experimenting with line-break related
callbacks. While the problem I was working on was ultimately better
solved using an engraver rather than a callback, there does not seem
to be a point in setting the "rhythmic-location" property much later
than "when".

http://codereview.appspot.com/295600043

Discussion

  • Anonymous

    Anonymous - 2016-06-17
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-06-17

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-21
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-21

    Patch on countdown for June 24th.

     
  • Anonymous

    Anonymous - 2016-06-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-06-24

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-06-24
    • labels: --> Fixed_2_19_45
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-06-24

    Pushed to staging as
    commit a975d6f176453d35367e3fa4808c7061d326a9e7
    Author: David Kastrup dak@gnu.org
    Date: Thu Jun 16 19:12:51 2016 +0200

    Issue 4898: Set rhythmic-location early in paper-column-engraver
    
    This makes it possible to refer to rhythmic-location in callbacks
    for PaperColumn grobs.
    
     
  • Federico Bruni

    Federico Bruni - 2016-07-17
    • status: Fixed --> Verified