Menu

#4886 Replace Grace_beam_engraver::listen_beam

Verified
Maintainability
2016-06-23
2016-06-05
No

Replace Grace_beam_engraver::listen_beam

The comment for it complains about copy&paste code, but the
actual code for Beam_engraver::listen_beam has evolved since
then and the changes, while seeming appropriate for the
Grace_beam_engraver as well, have not been copied over.

Deleting the listener callback and instead utilizing
the one from the base class Beam_engraver seems like
the sanest course of action.

http://codereview.appspot.com/295490043

Discussion

  • David Kastrup

    David Kastrup - 2016-06-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2016-06-06
     
  • Anonymous

    Anonymous - 2016-06-06
    • Needs: -->
    • Patch: new --> review
    • Type: --> Maintainability
     
  • Anonymous

    Anonymous - 2016-06-06

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-09
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-09

    Patch on countdown for June 12th.

     
  • Anonymous

    Anonymous - 2016-06-12
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-06-12

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-06-12
    • labels: --> Fixed_2_19_44
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-06-12

    Pushed to staging as
    commit ece0ac805c9705a936915114f82a4532b1b548dc
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 5 16:32:11 2016 +0200

    Issue 4886: Replace Grace_beam_engraver::listen_beam
    
    The comment for it complains about copy&paste code, but the
    actual code for Beam_engraver::listen_beam has evolved since
    then and the changes, while seeming appropriate for the
    Grace_beam_engraver as well, have not been copied over.
    
    Deleting the listener callback and instead utilizing
    the one from the base class Beam_engraver seems like
    the sanest course of action.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-23
    • status: Fixed --> Verified