Menu

#4884 Remove DECLARE_* translator callback macros

Verified
Maintainability
2016-06-17
2016-06-05
No

Remove DECLARE_* translator callback macros

Recent changes have rendered them trivial. This does not review their
accessibility status: in general, they should be protected since they
can be reused by derived classes but aren't needed externally.

http://codereview.appspot.com/301890043

Discussion

  • David Kastrup

    David Kastrup - 2016-06-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2016-06-06
    • labels: --> Fixed_2_19_43
    • status: Started --> Fixed
    • Patch: new -->
     
  • David Kastrup

    David Kastrup - 2016-06-06

    Pushed to staging as
    commit 0dcde4fc13c8091439fb8e2d77ea755357a0e7ed
    Author: David Kastrup dak@gnu.org
    Date: Sun Jun 5 18:52:47 2016 +0200

    Issue 4884: Remove DECLARE_* translator callback macros
    
    Recent changes have rendered them trivial.  This does not review their
    accessibility status: in general, they should be protected since they
    can be reused by derived classes but aren't needed externally.  However,
    where they are indeed called from static member functions of derived
    classes, the associated trampoline instantiation appears to require
    public access.  This might warrant some more investigation.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-17
    • status: Fixed --> Verified