Menu
▾
▴
#4880 Add ly:get-font-format to get the font format
Add ly:get-font-format to get the font format
Most of the OpenType/CFF Collection (OTC) fonts
have the extension *.ttc'.
TrueType Collection (TTC) fonts
also have the same extension*.ttc'.
However, it is necessary that different embed method,
between OTC and TTC.
So we need to distinguish them.
This commit adds ly:get-font-format
that can get font format for distinguishing them.
This issue is related to the Issue 4866, 4868.
https://sourceforge.net/p/testlilyissues/issues/4866/
https://sourceforge.net/p/testlilyissues/issues/4868/
Diff:
passes make, make check and a full make doc
Use symbol instead of string
http://codereview.appspot.com/296350043
passes make, make check and a full make doc.
p.s. please see Werner's comments on Rietveld.
I don't know if the comment on Rietveld means there is still some work to do or not, so I will leave this on Review. Otherwise please change this to countdown (June 9th).
I think this can be countdown.
I'd like to create another issue for rewriting "ly:pfb->pfa" to "ly:type1->pfa" and "font-file-as-ps-string" patch.
How about it?
No problem. Note that I don;t have technical expertise to make judgements like this - so I always defer to a developer's experience and judgement and as long as (like you have) make a valid comment when you change your own status, other developers can see that it is OK or can see your reasoning (when I cannot work it out).
Patch counted down - although on Rietveld I see that you have created https://sourceforge.net/p/testlilyissues/issues/4889/ out of a discussion with Werner.
If this patch needs to stay on review or is dependent on the patch above, then can you set this tracker back to an appropriate label, otherwise you can push it now.
This patch is independent on the Issue 4889.
So I've pushed to staging.
commit 887eee27389862497fd4754f24348c1d77c91999
Thanks.