#4877 Revert #4747: (Remove (all) uses of is-absolute?

[Urs Liska]

Revert #4747: (Remove (all) uses of is-absolute?

This reverts

commit f30a8189adbbeefa2103e2c2e194040f66bc2291
Author: Urs Liska ul@openlilylib.org
Date: Tue Jan 19 10:52:33 2016 +0100

#4747: Remove (all) uses of is-absolute?

====================

As discussion revealed the commit message is not true
and indicates a misconception (see quote below).
(car ly:input-file-line-char-column a-location) does
not always return an absolute path, instead this
depends on how the file path has been passed to LilyPond.

As this commit changed the behaviour of point-and-click
in a somewhat unintentional and unmaintainable way it
is better to revert the commit. Especially as the
original behaviour was not harmful in the first place.

========================

(Original commit message:)

The check for absolute paths in in output-ps.scm
and -svg.scm is unnecessary because
(car ly:input-file-line-char-column a-location)
always returns an absolute, slashified path

Now is-absolute? is not used anymore by LilyPond itself.

http://codereview.appspot.com/295470043

[David Kastrup]

Iff the revert went fine without any merge conflicts, the original state should have seen years in testing already. I don't see a point in additional manual testing then, in particular since it is highly unlikely to expose any syptoms of this change. I recommend to just push to staging and let the automated Patchy-staging fend off the worst offenses.

If you had to resolve merge conflicts manually, however, review would make more sense.

[Urs Liska]

No, went well.
OK, I'll let patchy to the "review" then.

[Urs Liska]

Pushed to staging as

commit b5b3e36d04fe1a35c9ffc5671b1351394783fbf6
Author: Urs Liska <ul@openlilylib.org>
Date:   Thu Jun 2 16:17:41 2016 +0200

    #4877: Revert #4747: (Remove (all) uses of is-absolute?)