Import various input session variables into parser

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4874 Import various input session variables into parser

Status: Verified

Owner: David Kastrup

Labels: Fixed_2_19_43 (26)

Needs:

Patch:

Type: Maintainability

Updated: 2016-06-17

Created: 2016-06-02

Creator: David Kastrup

Private: No

Import various input session variables into parser

This concerns pitchnames, drumPitchNames, and chordmodifiers,
saving a lookup for each use.

Also contains commits:

Turn pitch-related settings into session variables

This concerns pitchnames, default-language, previous-pitchnames,
drumPitchNames, and chordmodifiers.

Don't overwrite pre-bound session variables

This is necessary in order to use session variables
in lily-imports.cc

http://codereview.appspot.com/296330043

Discussion

David Kastrup - 2016-06-02

Protect define-session against double definitions

http://codereview.appspot.com/296330043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-03

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,4 @@ -Import various input session variables into parser + koImport various input session variables into parser This concerns pitchnames, drumPitchNames, and chordmodifiers, saving a lookup for each use.

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-03

fails make check on ../regression/display-lily-tests.ly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2016-06-03

Let define-session-public export after all for the sake of other modules

http://codereview.appspot.com/296330043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-03

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-03

passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-06

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-06

Patch on countdown for June 9th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-09

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-09

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2016-06-09

labels: --> Fixed_2_19_43

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,4 @@ - koImport various input session variables into parser + Import various input session variables into parser This concerns pitchnames, drumPitchNames, and chordmodifiers, saving a lookup for each use.

status: Started --> Fixed

Patch: push -->

Type: Enhancement --> Maintainability
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2016-06-09

Pushed to staging as
commit 88f80785a4eaa56c941bedcfe2c9508793eea2a5
Author: David Kastrup dak@gnu.org
Date: Thu Jun 2 14:18:48 2016 +0200

Issue 4874/3: Import various input session variables into parser This concerns pitchnames, drumPitchNames, and chordmodifiers, saving a lookup for each use.

commit 40c2941f2217f19a8b6c30ff75a030283b824b42
Author: David Kastrup dak@gnu.org
Date: Thu Jun 2 14:17:18 2016 +0200

Issue 4874/2: Turn pitch-related settings into session variables This concerns pitchnames, default-language, previous-pitchnames, drumPitchNames, and chordmodifiers.

commit 635394275d8eff363b09b232bb84ec04d3bcf64b
Author: David Kastrup dak@gnu.org
Date: Thu Jun 2 14:07:02 2016 +0200

Issue 4874/1: Don't overwrite pre-bound session variables This is necessary in order to use session variables in lily-imports.cc
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-06-17

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: