Menu

#4873 Give add_acknowledger SCM &, not Protected_scm &

Verified
Maintainability
2016-06-17
2016-06-01
No

Give add_acknowledger SCM &, not Protected_scm &

This one annoyed me, this looks cleaner.

Also contains commit:

operator SCM & () for Protected_scm

This allows passing SCM reference parameters that are
actually based on Protected_scm.

http://codereview.appspot.com/296310043

Discussion

  • Anonymous

    Anonymous - 2016-06-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-06-01

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-06

    Patch on countdown for June 9th.

     
  • David Kastrup

    David Kastrup - 2016-06-06
    • labels: --> Fixed_2_19_43
    • status: Started --> Fixed
    • Patch: countdown -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2016-06-06

    Pushed to staging as
    commit 014fe25e13112b1e215e2fec5d1a466f6a8ac255
    Author: David Kastrup dak@gnu.org
    Date: Wed Jun 1 20:57:26 2016 +0200

    Issue 4873/2: Give add_acknowledger SCM &, not Protected_scm &
    

    commit 91723da7360b372904979b2d572f3f941ebbc924
    Author: David Kastrup dak@gnu.org
    Date: Wed Jun 1 19:38:35 2016 +0200

    Issue 4873/1: operator SCM & () for Protected_scm
    
    This allows passing SCM reference parameters that are
    actually based on Protected_scm.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-17
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.