Added non-default property to KeySignature grob

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4869 Added non-default property to KeySignature grob

Status: Verified

Owner: Steven Weber

Labels: Fixed_2_19_44 (16)

Needs:

Patch:

Type: Enhancement

Updated: 2016-06-23

Created: 2016-05-30

Creator: Steven Weber

Private: No

Added non-default property to KeySignature grob

Added the non-default property to the KeySignature grob. It works
exactly like the non-default property for Clef - if the Key Signature
was created manually, it is set to true, otherwise it is unset.

Also updated the grob properties for non-default to indicate that
it works for both Clef and KeySignature grobs now.

https://codereview.appspot.com/300850043/

Discussion

Steven Weber - 2016-05-30

Patch: --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-31

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-31

Passes make and make doc but reg test show lots of identical errors for all (many) of the reg tests.

--snip--
Processing ./volta-broken-left-edge.ly' Parsing... Renaming input to:/home/jlowe/lilypond-git/input/regression/volta-broken-left-edge.ly'
-Interpreting music...[8][16][24]
+Interpreting music...
+programming error: Grob KeySignature' has no interface for propertynon-default'
+continuing, cross fingers
+[8][16][24]
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...
--snip--

This still needs some work it seems.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Steven Weber - 2016-06-01

Patch: needs_work --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Steven Weber - 2016-06-01

Updated patch with one more change (adding non-default to the key signature interface). Ran the regtests locally and verified the warning went away.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-01

Patch: review --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-01

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-01

Passes make, make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-06

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-06

Patch on countdown for June 9th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-09

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-09

Patch counted down - please push.

Steven if you do not have push access then send a git formatted patch to me (or the dev list) and I or someone else can push this for you.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-12

labels: --> Fixed_2_19_44

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-06-12

author Steven Weber panteck@hotmail.com
Fri, 27 May 2016 22:41:43 +0100 (14:41 -0700)
committer James Lowe pkx166h@gmail.com
Sun, 12 Jun 2016 09:52:45 +0100 (09:52 +0100)
commit 05ddf3b60d68b70afce5ff79992e725267bdca46

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-06-23

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: