Menu

#4860 Add halfopenvertical to script.scm

Verified
Enhancement
2016-07-17
2016-05-23
No

Add halfopenvertical to script.scm

http://codereview.appspot.com/297340043

Discussion

  • Anonymous

    Anonymous - 2016-06-01

    Make doc fails, I get this:

    --snip--

    Writing ./c2/lily-5c787a5a-1.signature
    Layout output to ./c2/lily-5c787a5a.eps'... Converting to./c2/lily-5c787a5a.pdf'...
    Converting to PNG...
    Layout output to ./c2/lily-5c787a5a-1.eps'... Converting to./c2/lily-5c787a5a-1.pdf'...
    Writing ./c2/lily-5c787a5a-systems.texi...
    Writing ./c2/lily-5c787a5a-systems.tex...
    Writing ./c2/lily-5c787a5a-systems.count...
    Processing `./0f/lily-73f7b3d9.ly'
    Parsing...
    fatal error: Unlisted scripts in Documentation/included/script-chart.ly: (halfopenvertical)

    --snip--

    This happens simultaneously for 5 instances for my -j6 run, but the message is the same each time.

    In this case ./0f/lily-73f7b3d9.ly is

    ly snippet:
    % **********
    \sourcefileline 1318
    \include "script-chart.ly"
    \new RhythmicStaff { \scriptStaff #instrument-specific }

    others in the error log are

    % ly snippet:
    % **********
    \sourcefileline 1309
    \include "script-chart.ly"
    \new RhythmicStaff { \scriptStaff #fermatas }

    % **********
    \sourcefileline 1300
    \include "script-chart.ly"
    \new RhythmicStaff { \scriptStaff #ornaments }

     
  • Anonymous

    Anonymous - 2016-06-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Carl Sorensen

    Carl Sorensen - 2016-06-12

    Fix documentation error. Now passes make and make doc on my machine

    http://codereview.appspot.com/297340043

     
  • Anonymous

    Anonymous - 2016-06-13
    • Needs: -->
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-06-13

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-13
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-06-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-15

    Patch on countdown for June 18th.

     
  • Anonymous

    Anonymous - 2016-06-18
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-06-18

    Patch counted down - please push.

     
  • Carl Sorensen

    Carl Sorensen - 2016-06-18
    • labels: --> Fixed_@_19_45
    • status: Started --> Fixed
    • Patch: push -->
     
  • Carl Sorensen

    Carl Sorensen - 2016-06-18

    Pushed to staging as ef61cca..dcf8c37

     
  • Carl Sorensen

    Carl Sorensen - 2016-06-18
    • labels: Fixed_@_19_45 --> Fixed_2_19_45
     
  • Federico Bruni

    Federico Bruni - 2016-07-17
    • labels: Fixed_2_19_45 --> Fixed_2_19_44
     
  • Federico Bruni

    Federico Bruni - 2016-07-17

    this commit was added before 2.19.44 release

     
  • Federico Bruni

    Federico Bruni - 2016-07-17
    • status: Fixed --> Verified