Menu

#4858 Let define-session-public place variables natively into parser

Verified
Defect
2016-06-17
2016-05-22
No

Let define-session-public place variables natively into parser

Putting them as native variables in the parser module (rather than
using export/import) makes set!' anddefine' equivalent rather than
having define' create a shadowing definition of the session variable. That is important in order to avoid the values of the variable diverging between parser module andlily'.

http://codereview.appspot.com/300110043

Discussion

  • David Kastrup

    David Kastrup - 2016-05-22
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Type: Enhancement --> Defect
     
  • Anonymous

    Anonymous - 2016-05-25
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-05-25

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-05-28
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-05-28

    Patch on countdown for May 31st

     
  • Anonymous

    Anonymous - 2016-05-31
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-05-31

    Patch counted down - please push

     
  • David Kastrup

    David Kastrup - 2016-05-31
    • labels: --> Fixed_2_19_43
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-05-31

    Pushed to staging as
    commit 5c2114fbd182303f4759f31aad6c662524a5d43e
    Author: David Kastrup dak@gnu.org
    Date: Sun May 22 13:54:40 2016 +0200

    Issue 4858: Let define-session-public place variables natively into parser
    
    Putting them as native variables in the parser module (rather than
    using export/import) makes `set!' and `define' equivalent rather than
    having `define' create a shadowing definition of the session variable.
    That is important in order to avoid the values of the variable
    diverging between parser module and `lily'.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-17
    • status: Fixed --> Verified