Menu

#4851 Scheme_engraver::init_acknowledgers API change

Verified
push
Maintainability
2016-06-17
2016-05-10
No

Scheme_engraver::init_acknowledgers API change

Nicer to return the constructed hash rather than pass it by reference.

http://codereview.appspot.com/291690043

Discussion

  • Anonymous

    Anonymous - 2016-05-12
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-05-12

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-05-12
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2016-05-12

    Oh sorry ... I though the tests had all passed, they hadn't. Make doc failed

    --snip--

    /home/james/lilypond-git/build/scripts/build/out/texi2omf --format pdf --location /usr/local/share/doc/lilypond/html/Documentation/snippets.pdf --version 2.19.42 /home/james/lilypond-git/Documentation/snippets.tely > out-www/snippets.pdf.omf
    rm -f lilypond
    mv ./out-www/tab-example.preview.png out-www/tab-example.png
    mv ./out-www/granados.preview.png out-www/granados.png
    ln -s ./out-www lilypond
    mkdir -p ./out-www/lilypond
    rm -f ./out-www/lilypond/[a-f0-9][a-f0-9]
    cd ./out-www/lilypond && /home/james/lilypond-git/build/scripts/build/out/mass-link symbolic .. . [a-f0-9][a-f0-9]
    touch out-www/lilypond.info-images-dir-dep
    mv ./out-www/ancient-headword.preview.png out-www/ancient-headword.png
    mv ./out-www/bach-bwv610.preview.png out-www/bach-bwv610.png
    mv ./out-www/cary.preview.png out-www/cary.png
    make[3]: Leaving directory '/home/james/lilypond-git/build/Documentation/ly-examples'
    /home/james/lilypond-git/./Documentation/GNUmakefile:230: recipe for target 'out-www/ly-examples' failed
    make[2]: *** [out-www/ly-examples] Error 2
    make[2]: *** Waiting for unfinished jobs....
    make[2]: Leaving directory '/home/james/lilypond-git/build/Documentation'
    /home/james/lilypond-git/stepmake/stepmake/generic-targets.make:166: recipe for target 'WWW-1' failed
    make[1]: *** [WWW-1] Error 2
    make[1]: Leaving directory '/home/james/lilypond-git/build'
    /home/james/lilypond-git/stepmake/stepmake/generic-targets.make:182: recipe for target 'doc-stage-1' failed
    make: *** [doc-stage-1] Error 2

     
    • David Kastrup

      David Kastrup - 2016-05-12

      This is the second unrelated test failing with this completely undescriptive error (there is nothing to be seen apart from a bad exit state).

      I suspect that there is something else broken here. Maybe some problem introduced by changes in the build scripts (via extra translations?). Maybe it only triggers in fresh directories or out-of-directory builds or something like that? Or you are running out of disk space?

       
  • Anonymous

    Anonymous - 2016-05-13
    • Patch: needs_work --> review
     
  • Anonymous

    Anonymous - 2016-05-13

    I did the patch test process manually again, step by step, and this passes make, make check and a full make doc. I do not know why the last three attempts failed (I usually redo a patch test twice if it fails the first time, in case I had something like a dirty tree or some other possible detritus left over from a previous patch).

     
    • David Kastrup

      David Kastrup - 2016-05-13

      Sometimes we have non-deterministic problems that make it through testing and into master. Then they occur occasionally in unrelated tests until one figures out where they come from. We may have one of those at our hand, or something was impacting your personal platform after all. Also I think that we have some CPU time limits in the git-cl config files: I remember having had to bump those for my rather weak platform some time ago. Since documentations were just recently changed to build more translations (I think) that might have caused your limits to trigger.

      But then it seems that the chances of this "fixing itself" would be small on a comparatively idle platform.

       
  • Anonymous

    Anonymous - 2016-05-17
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-05-17

    Patch on countdown for May 20th

     
  • Anonymous

    Anonymous - 2016-05-20
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-05-20

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-05-20

    I'm going to push a slightly reworked version that should expose a few variables better to garbage collection, in the hope that it might address some problems we've been seeing recently.

     
  • David Kastrup

    David Kastrup - 2016-05-21
    • labels: --> Fixed_2_19_43
    • status: Started --> Fixed
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2016-05-21

    Pushed to staging as
    commit 56a1519b44d1a0a8500c43236ae644053cc1f25b
    Author: David Kastrup dak@gnu.org
    Date: Tue May 10 15:51:58 2016 +0200

    Issue 4851: Scheme_engraver::init_acknowledgers API change
    
    Nicer to return the constructed hash rather than pass it by reference.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-17
    • status: Fixed --> Verified