There is no point any more in testing this patch before issue 4842 (due today) has been committed since the patches are in overlapping areas and the issue needs non-trivial rebasing.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ok, I think this might be the git-fetch problem that Phil has given some pointers to. Let's see whether this makes it through testing now.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-05-19
No, this ins't the problem at Savannah, I still cannot do a make doc after applying this patch and get the same error. I have destroyed by $LILYPOND_GIT dir and downloaded it all again, still the same problem. Remember that make check and make are fine. The error messaged is the same as above. I've looked at the files mentioned in the error message and it isn't conclusive
Pushed to staging as
commit a1467ba6de6240dda93009c907b05794ec9b8d54
Author: David Kastrup dak@gnu.org
Date: Mon May 9 20:09:21 2016 +0200
Issue 4850: Remove self method bindings of translator groups
They are not actually being used (and consequently untested), and the added
complexity makes understanding the code harder.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
In the midi*tex files I am getting variations on this when I look at the reg tests
@@ -15,6 +15,9 @@
Writing ./quantize-start-midi-systems.tex...
Writing ./quantize-start-midi-systems.count...
Writing timing to quantize-start-midi.profile...
+programming error: Parsed object should be dead: #<prob: music="" c++:="" music((value="" .="" #\<mom="" 15="">) (symbol . tempoWholesPerMinute))((display-methods #\<procedure #f="" (expr)="">) (name . PropertySet) (types layout-instruction-event) (iterator-ctor . #\<primitive-procedure ly:property-iterator::constructor="">) (untransposable . #t)) >
+
+continuing, cross fingers</primitive-procedure></procedure></prob:>
Writing timing to ./lily-run-total.profile...
Success: compilation successfully completed
I strongly suspect a fluke triggering of the respective error message unrelated to the actual change, so setting for retesting.
There is no point any more in testing this patch before issue 4842 (due today) has been committed since the patches are in overlapping areas and the issue needs non-trivial rebasing.
Rebase on master
http://codereview.appspot.com/297230043
Diff:
Passes make and make check but fails make doc.
I've attached the reg test diff which (if significant) still shows the programming errors.
Make doc fails thusly:
--snip--
...
cd ./out-www/lilypond && /home/james/lilypond-git/build/scripts/build/out/mass-link symbolic .. . [a-f0-9][a-f0-9]
touch out-www/lilypond.info-images-dir-dep
mv ./out-www/theory.preview.png out-www/theory.png
mv ./out-www/bach-schenker.preview.png out-www/bach-schenker.png
mv ./out-www/bach-bwv610.preview.png out-www/bach-bwv610.png
mv ./out-www/cary.preview.png out-www/cary.png
mv ./out-www/aucun-snippet.preview.png out-www/aucun-snippet.png
make[3]: Leaving directory '/home/james/lilypond-git/build/Documentation/ly-examples'
/home/james/lilypond-git/./Documentation/GNUmakefile:230: recipe for target 'out-www/ly-examples' failed
make[2]: *** [out-www/ly-examples] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/james/lilypond-git/build/Documentation'
/home/james/lilypond-git/stepmake/stepmake/generic-targets.make:166: recipe for target 'WWW-1' failed
make[1]: *** [WWW-1] Error 2
make[1]: Leaving directory '/home/james/lilypond-git/build'
/home/james/lilypond-git/stepmake/stepmake/generic-targets.make:182: recipe for target 'doc-stage-1' failed
make: *** [doc-stage-1] Error 2
--snip--
Ok, I think this might be the git-fetch problem that Phil has given some pointers to. Let's see whether this makes it through testing now.
No, this ins't the problem at Savannah, I still cannot do a make doc after applying this patch and get the same error. I have destroyed by $LILYPOND_GIT dir and downloaded it all again, still the same problem. Remember that make check and make are fine. The error messaged is the same as above. I've looked at the files mentioned in the error message and it isn't conclusive
$(MAKE) -C $(top-build-dir)/Documentation/po out=www messages
all I can do is keep looking to see what has 'suddenly' changed on my two different build systems.
But I still cannot reliably test patches.
Maybe I can try turning down the -j options, I'll have another go later today
OK so I did a j4 at work and that seemed to work this time.
Passes make, make check and a full make doc.
Patch on countdown for May 23rd.
Patch counted down - please push
Pushed to staging as
commit a1467ba6de6240dda93009c907b05794ec9b8d54
Author: David Kastrup dak@gnu.org
Date: Mon May 9 20:09:21 2016 +0200