LilyIssues / Issues / #4833 change download/ to downloads/

Federico Bruni - 2016-04-24

Description has changed:

Diff:

--- old +++ new @@ -33,8 +33,3 @@ > > The linuxaudio site is rsynched to the lilypond site with a cron job. > - - - - -Then someone should rename the directory on the server before running gub.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-04-24

here's the pull request:
https://github.com/gperciva/gub/pull/22

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-04-24

I was working on my laptop, where I did not run 'git-cl config' before uploading the patch. So I'm adding the rietveld url manually:
https://codereview.appspot.com/293220043/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -20,9 +20,10 @@
 Steps:

 1. Change URLs in gub: I'll send a pull request to gpercival/gub
-2. Add the downloads directory on the server
-3. Apply this patch
+2. Apply this patch to staging
+3. On the server rename download/ to downloads/
 4. Make a release
+5. Advise linuxaudio.org admin to update the cron job

 NOTE:  I guess that there's a cron job to be edited on the linuxaudio.org server. See below:

Patch: --> review

Phil Holmes - 2016-04-24

I need to check whether the cron job can be changed easily. It runs on the lilypond.org server (IIRC) but it's one of Jan's so I need to check whether I have permissions to edit it. Please don't push this patch until I've checked.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -21,11 +21,8 @@

 1. Change URLs in gub: I'll send a pull request to gpercival/gub
 2. Apply this patch to staging
-3. On the server rename download/ to downloads/
+3. On the server rename download/ to downloads/ and update the cronjob to rsync to linuxaudio.org
 4. Make a release
-5. Advise linuxaudio.org admin to update the cron job
-
-NOTE:  I guess that there's a cron job to be edited on the linuxaudio.org server. See below:

 > >     By the way, these are duplicates?
 > >

Anonymous - 2016-04-25

Leaving this on review.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-04-28

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-04-28

I'm going to put this on countdown - can someone give me a LGTM before May 1st else I'll have to put it back to review again.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-01

Patch: countdown --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-01

OK there's been no update on this for 2 countdonwns, I am not sure if this is good to go or not. I am putting this back to review.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-05-01

We are waiting for Jan to rename the directory on the server. Don't know how long it will take..

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-04

Leaving on review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-07

I'll still leave this on review. Has someone pinged Jan or perhaps someone else has pemissions to rename this dir on the server (e.g. Graham)?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-05-10

Jan renamed the directory, so the patch should be pushed.
Then Phil will have to merge the pull request for Gub and make the release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-10

Patch: review --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-05-10

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-05-12

cannot pull from the repository at the moment
I'm uploading the patch here and try again when I reach my computer at work later

0001-issue-4833-change-tarballs-directory-to-lilypond.org.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-05-12

labels: --> Fixed_2_19_42

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-05-12

pushed to staging:
8b1f2493e44c284398ce93ea9335cf126683a158

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Phil Holmes - 2016-05-18

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Phil Holmes - 2016-05-18

Required some further edits to gub: see

https://github.com/gperciva/gub/commit/dfa287fce0fce5fdbd627fb12321c0a180752c49

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

change download/ to downloads/

Issue Tracker for LilyPond

Searches

Help

#4833 change download/ to downloads/

Related

Discussion