Menu

#4818 engraver-init.ly: guarantee no ledger lines in NullVoice

Verified
Enhancement
2016-04-18
2016-04-02
Paul Morris
No

engraver-init.ly: guarantee no ledger lines in NullVoice

for staves with custom line positions and ledger
lines that appear inside the staff.

http://codereview.appspot.com/297730043

Discussion

  • Paul Morris

    Paul Morris - 2016-04-02
    % For example:
    
    \version "2.19.39"
    \new Staff {
      \override Staff.StaffSymbol.line-positions = #'(-8 -6 6 8)
      \new NullVoice {
        % \override NullVoice.NoteHead.no-ledgers = ##t
        g''''1
      }
    }
    
    % Also affects \partcombine which combines identical 
    % notes by moving one of them to a NullVoice:
    
    \new Staff {
      \override Staff.StaffSymbol.line-positions = #'(-8 -6 6 8)
      \partcombine
      { g''''1 }
      { g''''1 }
    }
    
     

    Last edit: Paul Morris 2016-04-02
  • Anonymous

    Anonymous - 2016-04-03
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-04-03

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-04-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-04-06

    Patch on countdown for April 9th.

     
  • Anonymous

    Anonymous - 2016-04-09
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-04-09

    Patch counted down - please push.

     
  • Paul Morris

    Paul Morris - 2016-04-10

    Pushed to staging.

     
  • Thomas Morley

    Thomas Morley - 2016-04-10

    Please always post commit id.
    I'd add commit-description as well:

    commit 1fe9ecabebaf686ebff62cc9b8e47bab43ff7b9e
    Author: Paul Morris paulwmorris@gmail.com
    Date: Sat Apr 2 13:10:35 2016 -0400

    engraver-init.ly: guarantee no ledger lines in NullVoice
    
    for staves with custom line positions and ledger
    lines that appear inside the staff.
    
     
  • Anonymous

    Anonymous - 2016-04-11
    • labels: --> Fixed_2_19_40
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-04-11

    author Paul Morris paulwmorris@gmail.com
    Sat, 2 Apr 2016 17:10:35 +0000 (13:10 -0400)
    committer Paul Morris paulwmorris@gmail.com
    Sun, 10 Apr 2016 19:07:24 +0000 (15:07 -0400)
    commit 1fe9ecabebaf686ebff62cc9b8e47bab43ff7b9e

     
  • Federico Bruni

    Federico Bruni - 2016-04-18
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.