Menu

#4811 Allow property paths as scalars and in assignments

Verified
Enhancement
2016-04-18
2016-03-23
No

Allow property paths as scalars and in assignments

They cannot be embedded LilyPond since #{ 2 . 2 #} already is valid
music.

Property paths must have at least two syntactic elements to be
recognized as such and must not start with a Scheme expression.
Technically, 3 . #'() counts.

This affects overrides and sets as well.

Also contains commits:

Run scripts/auxiliar/update-with-convert-ly.sh

convert-ly rule for nicer beatStructure syntax

http://codereview.appspot.com/290650043

Discussion

  • Simon Albrecht

    Simon Albrecht - 2016-03-23

    Amazing.

     
  • Anonymous

    Anonymous - 2016-03-24
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-03-24

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-03-25
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-03-25

    Patch on countdown for March 28th

     
  • Anonymous

    Anonymous - 2016-03-28
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-03-28

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2016-03-29
    • labels: --> Fixed_2_19_40
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2016-03-29

    Pushed to staging as
    commit 3ecc98aa5db8a47adcf9defc4ec9fc018c5cc47d
    Author: David Kastrup dak@gnu.org
    Date: Tue Mar 29 08:02:00 2016 +0200

    Run scripts/auxiliar/update-with-convert-ly.sh
    

    commit bb3285ff1f4cd437ba52afbaa53e7ff5946a7140
    Author: David Kastrup dak@gnu.org
    Date: Wed Mar 23 17:31:21 2016 +0100

    Issue 4811/2: convert-ly rule for nicer beatStructure syntax
    

    commit 2a66e23f356503ef916d51efa3f00cae5958dc48
    Author: David Kastrup dak@gnu.org
    Date: Wed Mar 23 00:05:16 2016 +0100

    Issue 4811/1: Allow property paths as scalars and in assignments
    
    They cannot be embedded LilyPond since #{ 2 . 2 #} already is valid
    music.
    
    Property paths must have at least two syntactic elements to be
    recognized as such and must not start with a Scheme expression.
    Technically, 3 . #'() counts.
    
    This affects overrides and sets as well.
    
     
  • Federico Bruni

    Federico Bruni - 2016-04-18
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB