If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-25
I am having a hard time getting the 'tracing object relationships' part of the CG to work using the instructions listed there. I've tried in and out of tree builds but always get this
I am sure it is a case of the instructions pre-supposing some prior knowledge (i.e. missing some step for someone like me who doesn't really understand all the ins and outs of building code).
So my steps go
./autogen.sh
./configure --enable-checking
make -C lily clean && make -C lily
Then I get the error (eventually)
make: *** No rule to make target '../flower/./out/library.a', needed by 'out/lilypond'. Stop.
and cannot get past that.
So is it a case of me needing to build the binary first and then do step #3 separately or something else?
James
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
That syntax looks quite odd. Someone else may be able to explain it, but -C means "change to this directory before running make" and then does not specify a directory. I would have thought that a simple "make clean" followed by "make" would do the job. Perhaps originally "lily" was a variable pointing to the build directory?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-25
Well I did that (just make normally) and I got as far as the dot command to make the pDF and I get this error:
jlowe@jloweDsktp ~/Desktop $ dot -Tpdf graphviz.log > graphviz.pdf
Error: graphviz.log: syntax error in line 38 near '-20'
So looking at line 38 of the edited log file I have this line:
Remarks:
I did make clean earlier
lilypond-git is my local script to invoke self-compiled lilypond
dev/graphviz is ofcourse the branch contaning the patch
I noticed no problems.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-26
Description has changed:
Diff:
Needs: -->
Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-26
I cannot test this patch using the method suggested by Thomas from the CG as it appears to no longer work (or we need more 'steps' or information for those that don't know enough about how graphviz and LP are supposed to work together).
So the least I can do is to test this the 'usual' way.
Passes make, make check and a full make doc.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-28
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-28
Patch on countdown for March 31st
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-31
Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2016-03-31
Patch counted down - please push.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
To test this it's best to use our regtest /input/regression/graphviz.ly following the steps explained in CG:
http://www.lilypond.org/doc/v2.19/Documentation/contributor/tracing-object-relationships
I am having a hard time getting the 'tracing object relationships' part of the CG to work using the instructions listed there. I've tried in and out of tree builds but always get this
I am sure it is a case of the instructions pre-supposing some prior knowledge (i.e. missing some step for someone like me who doesn't really understand all the ins and outs of building code).
So my steps go
Then I get the error (eventually)
make: *** No rule to make target '../flower/./out/library.a', needed by 'out/lilypond'. Stop.
and cannot get past that.
So is it a case of me needing to build the binary first and then do step #3 separately or something else?
James
That syntax looks quite odd. Someone else may be able to explain it, but -C means "change to this directory before running make" and then does not specify a directory. I would have thought that a simple "make clean" followed by "make" would do the job. Perhaps originally "lily" was a variable pointing to the build directory?
Well I did that (just make normally) and I got as far as the dot command to make the pDF and I get this error:
jlowe@jloweDsktp ~/Desktop $ dot -Tpdf graphviz.log > graphviz.pdf
Error: graphviz.log: syntax error in line 38 near '-20'
So looking at line 38 of the edited log file I have this line:
15 [label="NoteHead\n/home/jlowe/lilypond-git/lily/font-interface.cc:37\nfont <- #<Font_metric ("emmentaler-20" . 0.569055118110236"]
I've attached my log file if anyone is interested.
James, sorry to answer that late.
The error you observed is exactly what the patch tries to cure.
I've redone testing today with:
Remarks:
I did make clean earlier
lilypond-git is my local script to invoke self-compiled lilypond
dev/graphviz is ofcourse the branch contaning the patch
I noticed no problems.
Diff:
I cannot test this patch using the method suggested by Thomas from the CG as it appears to no longer work (or we need more 'steps' or information for those that don't know enough about how graphviz and LP are supposed to work together).
So the least I can do is to test this the 'usual' way.
Passes make, make check and a full make doc.
Patch on countdown for March 31st
Patch counted down - please push.
pushed to staging as
commit 6992c0bd640070493aeedcdb9f95be7c206e47d6
Author: Thomas Morley thomasmorley65@gmail.com
Date: Wed Mar 16 00:10:20 2016 +0100