LilyIssues / Issues / #4808 Make chord-naming robust against unsetting majorSevenSymbol

Issue Tracker for LilyPond

#4808 Make chord-naming robust against unsetting majorSevenSymbol

Status: Verified

Owner: Thomas Morley

Labels: Fixed_2.19.40 (1)

Needs:

Patch:

Type: Enhancement

Updated: 2016-04-18

Created: 2016-03-22

Creator: Thomas Morley

Private: No

Make chord-naming robust against unsetting majorSevenSymbol

This will likely be changed anyway as soon as rewriting
chord-names is seriously tackled.
At least it might be a reminder to take care of the possibility
a user wants to unset majorSevenSymbol.

http://codereview.appspot.com/288700043

Discussion

Thomas Morley - 2016-03-22

A test-case which the patch tries to improve

\new ChordNames \chordmode { \unset Score.majorSevenSymbol c:7+ }
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-22

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-22

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-03-23

Regtest amended

http://codereview.appspot.com/288700043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-23

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-23

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-25

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-25

Patch on countdown for March 28th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-28

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-03-28

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-03-28

labels: --> Fixed_2.19.40

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-03-28

pushed to staging as

commit 82e8427010b8e1a932e0642f03b0c94a8494f03a
Author: Thomas Morley thomasmorley65@gmail.com
Date: Tue Mar 22 11:32:53 2016 +0100

Issue 4808 Make chord-naming robust against unsetting majorSevenSymbol This will likely be changed anyway as soon as rewriting chord-names is seriously tackled. At least it might be a reminder to take care of the possibility a user wants to unset majorSevenSymbol. Regtest amended.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2016-03-28

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2016-04-18

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Make chord-naming robust against unsetting majorSevenSymbol

Issue Tracker for LilyPond

Searches

Help

#4808 Make chord-naming robust against unsetting majorSevenSymbol

Discussion