Menu

#4796 Doc: Extending - 1.3.4 - clarify description for 'addAccent' function example

Verified
Documentation
2016-03-30
2016-03-13
No

On 12/03/16 19:57, Mark D. Blackwell wrote:

The Extending LilyPond manual, in section 1.3.4:

http://www.lilypond.org/doc/v2.19/Documentation/extending/adding-articulation-to-notes-_0028example_0029

currently states:

"Now we transform the add-accent function into a music function (a
matter of some syntactic sugar and a declaration of the type of its
sole ‘real’ argument).

addAccent = #(define-music-function (note-event)
                                     (ly:music?)"

Now, the two words, "sole ‘real’" are mysterious and confusing, since
"note-event" is the only argument.

Formerly, those words referred to the fact that (in version 2.18) the
supplied arguments "parser" and "location" conveyed no information.
Compare version 2.18:

"Now we transform the add-accent function into a music function (a
matter of some syntactic sugar and a declaration of the type of its
sole ‘real’ argument).

addAccent = #(define-music-function (parser location note-event)
                                     (ly:music?)"

So the present text should be changed to:

"Now we transform the add-accent function into a music function (a
matter of some syntactic sugar and a declaration of the type of its
argument).

addAccent = #(define-music-function (note-event)
                                     (ly:music?)"

Discussion

  • Anonymous

    Anonymous - 2016-03-13

    Doc: Extending - 1.3.4 - clarify description for 'addAccent' function example

    Issue 4796

    Clarify description for
    the 'addAccent' function
    example in the Scheme
    Tutorial.

    http://codereview.appspot.com/290540043

     
  • Anonymous

    Anonymous - 2016-03-13
    • Needs: -->
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2016-03-13
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-03-13

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-03-16
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-03-16

    Patch on countdown for March 19th.

     
  • Anonymous

    Anonymous - 2016-03-19
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-03-19

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2016-03-21
    • labels: --> Fixed_2_19_39
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-03-21

    author James Lowe pkx166h@gmail.com
    Sun, 13 Mar 2016 11:34:32 +0000 (11:34 +0000)
    committer James Lowe pkx166h@gmail.com
    Mon, 21 Mar 2016 09:43:10 +0000 (09:43 +0000)
    commit dc75bffda220d1321689df595a976ab275debbba

     
  • Federico Bruni

    Federico Bruni - 2016-03-30
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB