Menu

#4781 Musicxml: Fix musicxml.py for Reg Test 42a

Verified
Enhancement
2016-04-13
2016-02-28
No

Musicxml: Fix musicxml.py for Reg Test 42a

MusicXML regression test
42a-MultiVoice-TwoVoicesOnStaff-Lyrics.xml
is missing the first note in
voice 2.

Subsequently the lyrics
of voice 2 is moved one note
to the right.

http://codereview.appspot.com/286480043

Discussion

  • Anonymous

    Anonymous - 2016-02-28
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -8,42 +8,3 @@
     Subsequently the lyrics
     of voice 2 is moved one note
     to the right.
    -
    -Issue 4776/2 Doc: Usage 1.2: update svg default font info
    -
    -Default svg font-family values are now
    -'serif' 'sans-serif' and 'monospace'
    -
    -Issue 4776/1 font.scm: better svg defaults for font-family
    -
    -if the user has not set the font, use a
    -meaningful svg default ('serif' 'sans-serif'
    -or 'monospace') for the font-family property
    -
    -Doc: NR - changing-defaults.itely - various improvements
    -
    -Issue 4761
    -
    -A variety of nitpicks and
    -improvements reported by
    -Federico Bruni
    -
    -Some spelling corrections
    -and typos fixed.
    -
    -The section on \set vs.
    -\override has been
    -edited in an attmpt to
    -simplify the explanation
    -for the reader.
    -
    -Fixed a couple of TODOs.
    -
    -Added a @c that references
    -an open issue to improve
    -the example for pure/unpure
    -containers as the example no
    -longer illustrates what it
    -used to as of LP 2.17.x +
    -
    -http://codereview.appspot.com/285650043
    
    • Needs: -->
     
  • Anonymous

    Anonymous - 2016-02-28

    Musicxml: Fix musicxml.py for Reg Test 42a

    MusicXML regression test
    42a-MultiVoice-TwoVoicesOnStaff-Lyrics.xml
    is missing the first note in
    voice 2.

    Subsequently the lyrics
    of voice 2 is moved one note
    to the right.

    http://codereview.appspot.com/286480043

     
  • Anonymous

    Anonymous - 2016-02-28
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -8,3 +8,5 @@
     Subsequently the lyrics
     of voice 2 is moved one note
     to the right.
    +
    +http://codereview.appspot.com/286480043
    
    • Needs: -->
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-02-28
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-02-28

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-03-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-03-01

    Patch on countdown for March 4th

     
  • Anonymous

    Anonymous - 2016-03-04
     
  • Anonymous

    Anonymous - 2016-03-04

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2016-03-04
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-03-04
    • labels: --> Fixed_2_19_38
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-03-04

    author Tobias Kretschmar tobias.kretschmar@gmx.de
    Sun, 28 Feb 2016 09:31:21 +0000 (09:31 +0000)
    committer James Lowe pkx166h@gmail.com
    Fri, 4 Mar 2016 20:33:24 +0000 (20:33 +0000)
    commit 9b42d0677d9dd04c0e9ccdb7a61d1529b5f7b434

     
  • Phil Holmes

    Phil Holmes - 2016-03-22
    • status: Fixed --> Verified
     
  • Phil Holmes

    Phil Holmes - 2016-04-13
    • status: Verified --> Fixed
     
  • Phil Holmes

    Phil Holmes - 2016-04-13
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB