Menu

#4776 svg output: better defaults for font-family

Verified
Enhancement
2016-03-02
2016-02-19
Paul Morris
No

output-svg.scm: better defaults for font-family

if the user has not set the font, use a
meaningful svg default ('serif' 'sans-serif'
or 'monospace') for the font-family property

http://codereview.appspot.com/290850043

Discussion

  • Anonymous

    Anonymous - 2016-02-19
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-02-19

    Passes make, make check and a full make doc.

     
  • Paul Morris

    Paul Morris - 2016-02-20

    Set svg defaults in font.scm instead and add doc edits

    http://codereview.appspot.com/290850043

     
  • Paul Morris

    Paul Morris - 2016-02-20

    fix whitespace in font.scm

    http://codereview.appspot.com/290850043

     
  • Paul Morris

    Paul Morris - 2016-02-20

    another whitespace fix (missed one space)

    http://codereview.appspot.com/290850043

     
  • Paul Morris

    Paul Morris - 2016-02-20
     
  • Paul Morris

    Paul Morris - 2016-02-20
    • summary: output-svg.scm: better defaults for font-family --> svg output: better defaults for font-family
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2016-02-21
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-02-21

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-02-24
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-02-24

    Patch on countdown for Feb 27th.

     
  • Anonymous

    Anonymous - 2016-02-27
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-02-27

    Patch counted down - please push.

    @Paul, you may want to apply for commit access yourself if you like as I think you've done enough work for the 'cause' to

    http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commit-access

     
  • Anonymous

    Anonymous - 2016-02-28
    • labels: --> Fixed_2_19_37
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-02-28

    author Paul Morris paulwmorris@gmail.com
    Sat, 20 Feb 2016 16:24:04 +0000 (11:24 -0500)
    committer James Lowe pkx166h@gmail.com
    Sun, 28 Feb 2016 09:21:24 +0000 (09:21 +0000)
    commit ead2001959fa5bda0338e92a0f301fd1f26ad768

    and

    author Paul Morris paulwmorris@gmail.com
    Sat, 20 Feb 2016 17:21:30 +0000 (12:21 -0500)
    committer James Lowe pkx166h@gmail.com
    Sun, 28 Feb 2016 09:21:36 +0000 (09:21 +0000)
    commit f44fba3ca586333ded5b25ff800b1ab63b54a0ba

     
  • Simon Albrecht

    Simon Albrecht - 2016-03-02
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.