Menu

#4771 Web: CSS: improve heading styles

Verified
Enhancement
2016-03-02
2016-02-13
Paul Morris
No

Web: CSS: improve heading styles

  • Remove dashed bottom borders
  • Adjust sizes and spacing
  • Restore previous dark blue heading color
    from 2.18 web manuals

http://codereview.appspot.com/290790043

Discussion

  • Anonymous

    Anonymous - 2016-02-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2016-02-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-02-18
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-02-18

    Patch on countdown for February 21st.

    N.B, (from Patch author on Rietveld).

    Just remove the spaces in the following URL (which have been added here to help
    thwart web crawlers/indexers (along with a robots.txt entry)).

    http://clairnote.org /lilypond-web-demo/

     
  • Anonymous

    Anonymous - 2016-02-21

    Paul, I am going to leave this on one more countdown if you don't mind. I didn't see any comments - which may be fine - but if we're altering the website and someone has missed this, another few days won't hurt I think.

     
    • Paul Morris

      Paul Morris - 2016-02-21

      That’s fine with me.

       
  • Simon Albrecht

    Simon Albrecht - 2016-02-21

    Sorry, but I’ve looked at a few pages in comparison of your new 2.19.37 and the official 2.19.36 version, and I really couldn’t see any difference (apart from the lacking ‘automatic language selection’ panel at the bottom). Is this because of my environment? (Firefox 44.0.2, Ubuntu 14.04 LTS)

     
  • Paul Morris

    Paul Morris - 2016-02-21

    The changes are pretty subtle. Basically, there’s no more dashed horizontal line below text headings, the text headings are a little larger, and they are blue instead of black. See attached screenshots.

    I found the dashed lines distracting and confusing (confusing because they were below the headings, separating them from the text they belong to). The changes to color and size add more contrast between the headings and the regular text, making them stand out more. The blue color is the same as the headings in the 2.18 docs.

    The missing 'automatic language selection' box at the bottom is just due to the website build I used to create the demo site (it's english only).

     
  • Simon Albrecht

    Simon Albrecht - 2016-02-22

    OK, that’s fine – apart from Times New Roman being used… I wonder if we might/should include a default web font here? Presumably TeX Gyre Schola, to stay in line with the engraving default.

     
  • Paul Morris

    Paul Morris - 2016-02-22

    Well, lilypond-manuals.css does not specify any font / font-family to be used and this patch doesn't change that. The browser just uses its default font. If we want to change that I think it deserves a separate issue and discussion.

     
  • Anonymous

    Anonymous - 2016-02-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-02-24

    Patch counted down - please push.

    @Simon A, if you want to submit a suggestion for changing the default web font, can you send the email to Bug?

     
  • Anonymous

    Anonymous - 2016-02-24
    • labels: --> Fixed_2_19_37
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2016-02-24

    author Paul Morris paulwmorris@gmail.com
    Thu, 11 Feb 2016 17:49:28 +0000 (12:49 -0500)
    committer James Lowe pkx166h@gmail.com
    Wed, 24 Feb 2016 19:11:32 +0000 (19:11 +0000)
    commit 437e0103f4a2c55b92ed933359e0ecc68121981c

    Thank you as always Paul.

     
  • Simon Albrecht

    Simon Albrecht - 2016-03-02
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.