Menu ▾ ▴

#4749 Doc: Minor, superficial changes to CG, Extending, LM and paper-defaults.ly

Verified
Simon Albrecht
Fixed_2_19_37 (20)
Documentation
2016-03-02
2016-01-23
Simon Albrecht
No

These are a number of things which accumulated and didn’t warrant an issue of their own.
https://codereview.appspot.com/281510043

Contains commits:

  • Better code formatting in some alists Previously, the 110-character lines made it difficult to read; the new version is also in line with what the NR says.
  • Doc Ext: comment TODO remark Telling the user that he might be confused about something (while he doesn’t understand what exactly that is) only adds to confusion; I find it odd to have this on the surface.
  • Doc: properly format formatted example This should actually show how reformatting Scheme code makes it easier to read; however, it uses tabs and the result in both HTML and PDF is a total mess. The new version uses normal spaces only and should be consistent as well as clear.
  • Doc: minor wording and punctuation improvements
  • Doc: always capitalize LilyPond correctly
  • Fix typo in LM (follow-up to 4582) There was an unmatched parenthesis in the text; changed into a comma.

Discussion

  • Anonymous

    Anonymous - 2016-01-24
    • summary: Patch: a bunch of minor, superficial changes --> Doc: Minor, superficial changes to CG, Extending, LM and paper-defaults.ly
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2016-01-24

    Passes make, make check and a f ull make doc.

    NB: Can we make sure that the description (as well as title) of this patch are a bit more descriptive in terms of whcih files are being changed - especially as it is multiple files - than 'a bunch of changes' please?

    Thanks

     

    • Simon Albrecht

      Simon Albrecht - 2016-01-24

      Done. Sorry, I should have been more careful.

       

  • Simon Albrecht

    Simon Albrecht - 2016-01-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,2 +1,10 @@
 These are a number of things which accumulated and didn’t warrant an issue of their own.
 https://codereview.appspot.com/281510043
+
+Contains commits:
+* **Better code formatting in some alists** Previously, the 110-character lines made it difficult to read; the new version is also in line with what the NR says.
+* **Doc Ext: comment TODO remark** Telling the user that he might be confused about something (while he doesn’t understand what exactly that is) only adds to confusion; I find it odd to have this on the surface.
+* **Doc: properly format formatted example** This should actually show how reformatting Scheme code makes it easier to read; however, it uses tabs and the result in both HTML and PDF is a total mess. The new version uses normal spaces only and should be consistent as well as clear.
+* **Doc: minor wording and punctuation improvements**
+* **Doc: always capitalize LilyPond correctly**
+* **Fix typo in LM (follow-up to 4582)** There was an unmatched parenthesis in the text; changed into a comma.
     

  • Simon Albrecht

    Simon Albrecht - 2016-01-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,6 +2,7 @@
 https://codereview.appspot.com/281510043

 Contains commits:
+
 * **Better code formatting in some alists** Previously, the 110-character lines made it difficult to read; the new version is also in line with what the NR says.
 * **Doc Ext: comment TODO remark** Telling the user that he might be confused about something (while he doesn’t understand what exactly that is) only adds to confusion; I find it odd to have this on the surface.
 * **Doc: properly format formatted example** This should actually show how reformatting Scheme code makes it easier to read; however, it uses tabs and the result in both HTML and PDF is a total mess. The new version uses normal spaces only and should be consistent as well as clear.
     

  • Anonymous

    Anonymous - 2016-01-27
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2016-01-27

    Patch on countdown for January 30th

     

  • Anonymous

    Anonymous - 2016-01-30
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2016-01-30

    Patch counted down - please push.

     

  • Anonymous

    Anonymous - 2016-02-02
    • labels: --> Fixed_2_19_37
    • status: Started --> Fixed
    • Patch: push -->
     

  • Anonymous

    Anonymous - 2016-02-02

    author Simon Albrecht simon.albrecht@mail.de
    Tue, 2 Feb 2016 19:38:22 +0000 (19:38 +0000)
    committer James Lowe pkx166h@gmail.com
    Tue, 2 Feb 2016 19:39:10 +0000 (19:39 +0000)
    commit bfd8ed4084a441d9ac65b1b088f3b54f31ae40c6

     

  • Simon Albrecht

    Simon Albrecht - 2016-03-02
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB