Menu
▾
▴
#4743 Add ly:one-line-auto-height-breaking
Add ly:one-line-auto-height-breaking
Includes 4 commits:
Changes entry for ly:one-line-auto-height-breaking
Doc: NR 4.3.2 add ly:one-line-auto-height-breaking
Includes a few related edits to NR 4.3.2
mainly for ly:one-line-breaking
Add regtest for ly:one-line-auto-height-breaking
Add ly:one-line-auto-height-breaking
Passes make, make check and a full make doc.
Diff:
Just for the record, I experimented with setting top-system-spacing to 0 in the "one-line-auto-height-breaking.cc" file like so:
book_->paper_->set_variable (ly_symbol2scm ("top-system-spacing"), scm_from_int (0));But this had no effect as far as I could tell. (Perhaps top-system-spacing is given a value later and any changes made here are overwritten?)
To illustrate what happens with top-system-spacing, attached are a couple of images with all margins set to 1. One shows leaving top-system-spacing unchanged (which pushes the music down so it falls off the bottom of the page) and one shows it set to 0 (so that the music is centered vertically between the top and bottom margins).
I assume that for many use cases, top-system-spacing will need to be set to 0, so I included a note about that in the documentation.
This looks like it still needs work from comments in Rietveld.
a few documentation edits
http://codereview.appspot.com/284240043
passes make, make check and a full make doc.
Patch on countdown for Jan 24th
Patch counted down - please push.
author Paul Morris paulwmorris@gmail.com
Sun, 24 Jan 2016 02:43:09 +0000 (21:43 -0500)
committer James Lowe pkx166h@gmail.com
Sun, 24 Jan 2016 20:34:37 +0000 (20:34 +0000)
commit 01b15679731ac5fcaf8edac1ad5bce6acba10ff0
and
author Paul Morris paulwmorris@gmail.com
Sun, 24 Jan 2016 02:38:16 +0000 (21:38 -0500)
committer James Lowe pkx166h@gmail.com
Sun, 24 Jan 2016 20:33:15 +0000 (20:33 +0000)
commit b17364183c12506d30bfc19bcbf650c4441b7949