Menu
▾
▴
1 Attachments
#472 collision rest + (accidental/notehead) with beaming
Originally created by: *anonymous
Originally created by: gpermus@gmail.com
Originally owned by: k-ohara5...@oco.net
%{
possibly dupe of 37 or 217
In the following snippet, manual beams over rests force them be
printed higher than their normal placement. However, the other grobs
(accidentals, and even notes) don't take this change into account when
spacing is tight, thus provoking unwanted collisions.
(I added accidentals to make the collisions obvious, but if you remove
them, the b in the chord still collides with the rests).
%}
\version "2.11.32"
\paper {
ragged-right = ##t
}
{
<f'' b'' c''' f'''>16[ r <f'' bes'' c''' f'''> <f'' b'' c''' f'''>]
}
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Owner: ---
Originally posted by: k-ohara5...@oco.net
Workarounds are
1) Pitched rests, in the example above replace r by a''\rest
2) \override Rest #'extra-spacing-height = #'(-3 . 3)
Originally posted by: mts...@gmail.com
http://codereview.appspot.com/4860043
Labels: Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Passes make and reg tests
Labels: -Patch-new
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -type-Collision Type-Ugly
Originally posted by: mts...@gmail.com
Fixed with [r9c319db89ecc46cbf6c9c35e759eba973e412bb0].
Status: Fixed
Originally posted by: k-ohara5...@oco.net
The commit above was the merge, the fix is 49ef4f0e
Labels: -Type-Ugly fixed_2_15_9
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: k-ohara5...@oco.net
Very similar cases still have the same collision. This case was set correctly in version 2.16, but now collides
\version "2.17.19"
{ <d' d''>16[ r <bes' bes''> <bes' bes''>] [r4] }
Labels: -fixed_2_15_9
Status: Accepted
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Priority-Low -Patch-review Type-Ugly
Originally posted by: k-ohara5...@oco.net
Issue 4185 has been merged into this issue.
Originally posted by: k-ohara5...@oco.net
The rest position is not finalized until the beam is set, but the estimated position should be accurate enough for horizontal spacing. After the patch, the estimate for spacing (blue/yellow outlines) seems to be always a staff-space closer to the beam than the final position. Probably a bug in the patch linked above.
\layout { \context { \Score
\override PaperColumn #'stencil = #ly:separation-item::print
}} #(ly:set-option 'debug-skylines)
\relative c' {
<gis' cis e>8[ [r8] <fis gis dis'> <e gis cis>] }
Originally posted by: k-ohara5...@oco.net
The old patch was estimating the rest position as moved right up against the beam, but the rests do not really move toward the beam, only away.
I also made the last example of beam-rest-extreme.ly less extreme to check that we space rests under less-extreme beams.
http://codereview.appspot.com/179320043
Labels: Patch-new
Owner: k-ohara5...@oco.net
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
Reg test diff attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for Nov 29th (NB minor nit it seems by Werner on Rietveld).
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push (remember the minor nit from Werner on Rietveld before you push)
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
The example at the top should be spaced with no overlap in version 2.19.16
Labels: -Patch-push Fixed_2_19_16
Status: Fixed
Originally posted by: stans...@gmail.com
verified
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Status: Verified