#4718 In-chord tie in cue causes segfault

[Simon Albrecht]

Patrick Karl reported this problem with an in-chord tie in a cue:

:::TeX
\version "2.19.32"

music = {
  \cueDuring #"cueNotes" #DOWN  r4
}

cueNotes = {
  <g b~>8 b
}

\addQuote "cueNotes" \cueNotes

\score {
  \new Staff \new Voice \music
}

This segfaults while interpreting music.

[David Kastrup]

It's not specific to ties. Any in-chord articulation will have the same effect.

[David Kastrup]

I would think that the patch for https://sourceforge.net/p/testlilyissues/issues/2484/ is responsible. That would be

commit 338b1a48ec8b2fb282ffb46fc96c00dcfaa15620
Author: David Kastrup dak@gnu.org
Date: Tue Apr 17 11:48:57 2012 +0200

Let pitched trills in articulations be transposed as well

Uhm, can anybody find evidence that this ever did something useful?

[David Kastrup]

Ok, it does for ordinary \transpose on pitched trills. But it crashes quoting of in-chord articulations.

[David Kastrup]

Issue 4718/1: In-chord tie in cue causes segfault

This extends transposition functionality from Music expressions to
Prob in general since Stream_event also needs transposition in the
context of quoted music. While at top level, Stream_event is
processed using the container-agnostic transpose_mutable, this does
not extend to the actual contents, and at least a Stream_event's
articulation list does not consist of Music expressions but again of
Stream_event elements.

Also contains commits:

Issue 4718/2: Let transpose_music_list act defensively for non-Prob members

Issue 4718/3: Let Quote_iterator::process use Prob::transpose

Issue 4718/4: Fold transpose_mutable into Prob::transpose

It's not really needed elsewhere anymore.

http://codereview.appspot.com/290380043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for March 4th

[Anonymous]

Patch counted down - please push

[Anonymous]

author David Kastrup dak@gnu.org
Sat, 27 Feb 2016 10:41:08 +0000 (11:41 +0100)
committer David Kastrup dak@gnu.org
Fri, 4 Mar 2016 11:36:35 +0000 (12:36 +0100)
commit 3d54e4a6f45ccfb3847290cd0bdbefe4d21d7924

author David Kastrup dak@gnu.org
Sat, 27 Feb 2016 10:53:49 +0000 (11:53 +0100)
committer David Kastrup dak@gnu.org
Fri, 4 Mar 2016 11:36:35 +0000 (12:36 +0100)
commit d8bd48a1e6beee87bd0bca2fcafb742b1ea6712b

author David Kastrup dak@gnu.org
Sat, 27 Feb 2016 11:00:59 +0000 (12:00 +0100)
committer David Kastrup dak@gnu.org
Fri, 4 Mar 2016 11:36:35 +0000 (12:36 +0100)
commit 5c88d2869dd785815d2c132995cdf456ca5bd842

author David Kastrup dak@gnu.org
Sat, 27 Feb 2016 11:35:04 +0000 (12:35 +0100)
committer David Kastrup dak@gnu.org
Fri, 4 Mar 2016 11:36:35 +0000 (12:36 +0100)
commit 2606faf48590c90bd488a8944c7612acef11ed8c