Changes minimum-space to extra-space in BarLine.space-alist.clef

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4694 Changes minimum-space to extra-space in BarLine.space-alist.clef

Status: Verified

Owner: Thomas Morley

Labels: Fixed_2_19_34 (13)

Needs:

Patch:

Type: Enhancement

Updated: 2016-01-03

Created: 2015-12-13

Creator: Thomas Morley

Private: No

Changes minimum-space to extra-space in BarLine.space-alist.clef

Prevents bad spacing, if Clef is forced to be displayed after BarLine
via changed BreakAlignment.break-align-orders

http://codereview.appspot.com/277320043

Discussion

Anonymous - 2015-12-14

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-14

Passes make, make check and a full make doc.

Does this need a reg test?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-12-14

Well, we have no regtest focusing on 'space-alist, as far as I can tell.
Probably because there are far too many combinations how items can be ordered with 'break-align-orders.

The only one I found which uses BarLine.space-alist is
input/regression/cue-clef-after-barline.ly
which uses 'minimum-space.
Btw, I have no good idea what this one tests...

If you add
\override Staff.BarLine.hair-thickness = 10
you can trigger bad spacing, would be cured by changing to 'extra-space

So, I'm undecided whether a general regtest for 'space-alist or a regtest for BarLine.space-alist is desireable or none at all.

What do others think?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-16

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-16

Patch on countdown for December 19th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-19

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-19

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-12-19

pushed to staging as

commit 858f2d054103f6b99e82bcfc535c71ea35f146d8
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sun Dec 13 13:52:30 2015 +0100

Changes minimum-space to extra-space in BarLine.space-alist.clef issue 4694 Prevents bad spacing, if Clef is forced to be displayed after BarLine via changed BreakAlignment.break-align-orders
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-12-19

labels: --> Fixed_2_19_34

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Simon Albrecht - 2016-01-03

status: Fixed --> Verified

assigned_to: Thomas Morley --> nobody
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Simon Albrecht - 2016-01-03

assigned_to: Thomas Morley
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: