#4678 SVG <tspan> with leading/trailing spaces should use non-break spaces

http://codereview.appspot.com/323420043

On Mon, Nov 2, 2015 at 7:27 PM, Ophir Lifshitz hangfromthefloor@gmail.com
wrote:

Hello all,

Here is the MWE:

$ echo '\version "2.18.2" { \tempo "Foo" 4 = 20 b }' | lilypond
-dbackend=svg -o foo -

It seems the easiest way to fix this is to render elements with
leading or trailing spaces converted to non-break spaces:

Incorrect: = 20
Correct:  = 20

See attached screenshots.

Thanks,
Ophir

[Étienne Beaulé]

The problem here seems to be that the "=20" is not in the same <text tag as the closing parenthesis. Annoying thing. This isn't really related to the <tspan tags though. The metronome mark's first parenthesis is not even in the same tag as the tempo indication (when it exists).

[Étienne Beaulé]

Implemented your solution (and it had precedent in LY). I'll submit a patch very soon. Could someone set the correct flags on this issue? Thanks!

[Étienne Beaulé]

Issue 4678: Fix spaces in metronome mark

This change specifies the types of spaces used in the metronome
markings as comments. It also changes the type of space to non-breaking
around the equals sign. The change also improves readability by
combining chars into strings.

http://codereview.appspot.com/323420043

[Étienne Beaulé]

Exclusively Scheme code, so make is un-necessary.

[Phil Holmes]

Patch testing also includes make doc and make test (checking for changes in regtests) so bypassing this stage is not recommended.

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for August 17th.

[Anonymous]

There's a comment by David K on Rietveld, so I am going to leave this on Review for now.

[Étienne Beaulé]

Duplicate of [#1434].